On Tue, 9 Jun 2026 17:13:02 -0500 Maxwell Doose <[email protected]> wrote:
> On Tue, 09 Jun 2026 11:13:06 +0100 > Rodrigo Alencar via B4 Relay > <[email protected]> wrote: > > > From: Rodrigo Alencar <[email protected]> > > > > Use guarded mutex lock to facilitate code review when adding new > > attributes. This will allow for early returns, avoiding error-prone > > locking and unlocking in error paths. Gain-control support will add > > the scale attribute. > > > > Signed-off-by: Rodrigo Alencar <[email protected]> > > --- > > drivers/iio/dac/ad5686.c | 14 +++++--------- > > 1 file changed, 5 insertions(+), 9 deletions(-) > > > > I agree with Joshua on this, linux/cleanup.h should definitely be > included. However I don't think sending a v3 is worth the trouble > (Jonathan may tweak while applying but I wouldn't count on it), so with > or without: > > Reviewed-by: Maxwell Doose <[email protected]> > Although I will note that it appears that you haven't converted all of the locks to guard(mutex)(). While its only in two spots you should probably convert all of them. Either way, patch is obviously correct (besides IWYU), so I still stand by my rb. -- best regards, max
