>> +            /*
>> +             * Speculative reference can temporarily prevent some
>> +             * pages from getting dropped. So sleep and retry.
>> +             *
>> +             * If a page is not droppable for 10s, something
>> +             * is seriously messed up and we want to fail.
>> +             */
>> +            if (dropped)
>> +                    break;
>> +            sleep(1);
>>      }
>> -    kill(child, SIGTERM);
>>  
>> -    ksft_test_result_pass("MAP_DROPPABLE: PASS\n");
>> -    exit(KSFT_PASS);
>> +    ksft_test_result(dropped, "madvise(MADV_PAGEOUT) behavior\n");
> 
> You meant "MAP_DROPPABLE" behaviour? Perhaps that can be folded in.

No, I did mean "madvise(MADV_PAGEOUT)" behaves as expected with droppable pages.

Reasoning being that we might want to add some other tests in the future that
trigger reclaim differently.

Thanks!

-- 
Cheers,

David

Reply via email to