On 6/10/26 21:28, David Heidelberg via B4 Relay wrote:
From: David Heidelberg <[email protected]>
The lane mask must be multiplied by 2, but this was accidentally omitted.
Fortunately this computed lane mask value has never been used expectedly by
csiphy-3ph users.
Fixes: c94d21ffa814 ("media: camss: Add CSIPHY files")
Cc: [email protected]
Suggested-by: Nihal Kumar Gupta <[email protected]>
Signed-off-by: David Heidelberg <[email protected]>
Fixes shall be the first patches in any series, please reorder for v9.
Then, formally it looks like a fix, but to my understanding it's just a noop
change against the current upstream codebase, thus the change is not justified
to gain the Fixes tag, see Documentation/process/stable-kernel-rules.rst.
---
drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c
b/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c
index dac8d2ecf7995..7c8c0e41bc62f 100644
--- a/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c
+++ b/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c
@@ -1114,17 +1114,17 @@ static void csiphy_gen2_config_lanes(struct
csiphy_device *csiphy,
static u8 csiphy_get_lane_mask(struct csiphy_lanes_cfg *lane_cfg)
{
u8 lane_mask;
int i;
lane_mask = CSIPHY_3PH_CMN_CSI_COMMON_CTRL5_CLK_ENABLE;
for (i = 0; i < lane_cfg->num_data; i++)
- lane_mask |= 1 << lane_cfg->data[i].pos;
+ lane_mask |= BIT(lane_cfg->data[i].pos * 2);
return lane_mask;
}
static bool csiphy_is_gen2(u32 version)
{
bool ret = false;
After dropping Fixes tag and cc to stable,
Reviewed-by: Vladimir Zapolskiy <[email protected]>
--
Best wishes,
Vladimir
