On Wed, 10 Jun 2026 16:09:07 -0700, Vipin Sharma <[email protected]> wrote: > diff --git a/tools/testing/selftests/liveupdate/lib/libliveupdate.mk > b/tools/testing/selftests/liveupdate/lib/libliveupdate.mk > new file mode 100644 > index 000000000000..0fb738c02330 > --- /dev/null > +++ b/tools/testing/selftests/liveupdate/lib/libliveupdate.mk > @@ -0,0 +1,20 @@ > [ ... skip 14 lines ... ] > + $(Q)mkdir -p $@ > + > +$(LIBLIVEUPDATE_O): $(LIBLIVEUPDATE_OUTPUT)/%.o : > $(LIBLIVEUPDATE_SRCDIR)/%.c | $(LIBLIVEUPDATE_OUTPUT) > + $(CC) $(CFLAGS) $(CPPFLAGS) $(TARGET_ARCH) -c $< -o $@ > + > +EXTRA_CLEAN += $(LIBLIVEUPDATE_OUTPUT)
since this file contains utility functions (luo_open_device, luo_test, etc.), naming it liveupdate.c makes it sound like the main implementation rather than a test helper library. Using something distinct like lu_utils.c would make more sense. > > diff --git a/tools/testing/selftests/liveupdate/luo_test_utils.c > b/tools/testing/selftests/liveupdate/lib/liveupdate.c > similarity index 99% > rename from tools/testing/selftests/liveupdate/luo_test_utils.c > rename to tools/testing/selftests/liveupdate/lib/liveupdate.c > index 333a3530051b..897c200f3845 100644 > --- a/tools/testing/selftests/liveupdate/luo_test_utils.c > +++ b/tools/testing/selftests/liveupdate/lib/liveupdate.c > @@ -22,7 +22,7 @@ > #include <errno.h> > #include <stdarg.h> > > -#include "luo_test_utils.h" > +#include <libliveupdate.h> Linux kernel coding style generally prefers block headers to be sorted alphabetically. > > diff --git a/tools/testing/selftests/liveupdate/liveupdate.c > b/tools/testing/selftests/liveupdate/liveupdate.c > index 502fb3567e38..6bfd4e53528c 100644 > --- a/tools/testing/selftests/liveupdate/liveupdate.c > +++ b/tools/testing/selftests/liveupdate/liveupdate.c > @@ -25,8 +25,8 @@ > #include <unistd.h> > > #include <linux/liveupdate.h> > +#include <libliveupdate.h> Please sort alphabetically -- Pasha Tatashin <[email protected]>
