From: Jack Thomson <[email protected]>

Add a -s option to specify different memory backing types for the
pre-fault tests (e.g. anonymous, hugetlb), allowing testing of the
pre-fault functionality across different memory configurations.

Signed-off-by: Jack Thomson <[email protected]>
---
 .../selftests/kvm/pre_fault_memory_test.c     | 51 +++++++++++++------
 1 file changed, 36 insertions(+), 15 deletions(-)

diff --git a/tools/testing/selftests/kvm/pre_fault_memory_test.c 
b/tools/testing/selftests/kvm/pre_fault_memory_test.c
index 9f5f0d1a5db1..c850cf28e86a 100644
--- a/tools/testing/selftests/kvm/pre_fault_memory_test.c
+++ b/tools/testing/selftests/kvm/pre_fault_memory_test.c
@@ -45,6 +45,7 @@ struct slot_worker_data {
        struct kvm_vm *vm;
        gpa_t gpa;
        u32 flags;
+       enum vm_mem_backing_src_type mem_backing_src;
        bool worker_ready;
        bool prefault_ready;
        bool recreate_slot;
@@ -65,14 +66,16 @@ static void *delete_slot_worker(void *__data)
        while (!READ_ONCE(data->recreate_slot))
                cpu_relax();
 
-       vm_userspace_mem_region_add(vm, VM_MEM_SRC_ANONYMOUS, data->gpa,
+       vm_userspace_mem_region_add(vm, data->mem_backing_src, data->gpa,
                                    TEST_SLOT, test_config.test_num_pages, 
data->flags);
 
        return NULL;
 }
 
 static void pre_fault_memory(struct kvm_vcpu *vcpu, u64 base_gpa, u64 offset,
-                            u64 size, u64 expected_left, bool private)
+                            u64 size, u64 expected_left,
+                            enum vm_mem_backing_src_type mem_backing_src,
+                            bool private)
 {
        struct kvm_pre_fault_memory range = {
                .gpa = base_gpa + offset,
@@ -83,6 +86,7 @@ static void pre_fault_memory(struct kvm_vcpu *vcpu, u64 
base_gpa, u64 offset,
                .vm = vcpu->vm,
                .gpa = base_gpa,
                .flags = private ? KVM_MEM_GUEST_MEMFD : 0,
+               .mem_backing_src = mem_backing_src,
        };
        bool slot_recreated = false;
        pthread_t slot_worker;
@@ -172,11 +176,13 @@ static void pre_fault_memory(struct kvm_vcpu *vcpu, u64 
base_gpa, u64 offset,
 struct test_params {
        unsigned long vm_type;
        bool private;
+       enum vm_mem_backing_src_type mem_backing_src;
 };
 
 static void __test_pre_fault_memory(enum vm_guest_mode guest_mode, void *arg)
 {
        gpa_t gpa, gva, alignment, guest_page_size, host_page_size;
+       gpa_t backing_src_pagesz, mem_page_size;
        struct test_params *p = arg;
        const struct vm_shape shape = {
                .mode = guest_mode,
@@ -188,24 +194,28 @@ static void __test_pre_fault_memory(enum vm_guest_mode 
guest_mode, void *arg)
        struct ucall uc;
 
        pr_info("Testing guest mode: %s\n", vm_guest_mode_string(guest_mode));
+       pr_info("Testing memory backing src type: %s\n",
+               vm_mem_backing_src_alias(p->mem_backing_src)->name);
 
        vm = vm_create_shape_with_one_vcpu(shape, &vcpu, guest_code);
 
        guest_page_size = vm_guest_mode_params[guest_mode].page_size;
        host_page_size = getpagesize();
+       backing_src_pagesz = get_backing_src_pagesz(p->mem_backing_src);
+       mem_page_size = max(host_page_size, backing_src_pagesz);
 
        test_config.page_size = guest_page_size;
        test_config.test_size = align_up(TEST_BASE_SIZE + test_config.page_size,
-                                        host_page_size);
+                                        mem_page_size);
        test_config.test_num_pages = vm_calc_num_guest_pages(vm->mode, 
test_config.test_size);
 
        gpa = (vm->max_gfn - test_config.test_num_pages) * 
test_config.page_size;
        alignment = SZ_2M;
-       alignment = max(alignment, host_page_size);
+       alignment = max(alignment, mem_page_size);
        gpa = align_down(gpa, alignment);
        gva = gpa & ((1ULL << (vm->va_bits - 1)) - 1);
 
-       vm_userspace_mem_region_add(vm, VM_MEM_SRC_ANONYMOUS,
+       vm_userspace_mem_region_add(vm, p->mem_backing_src,
                                    gpa, TEST_SLOT, test_config.test_num_pages,
                                    p->private ? KVM_MEM_GUEST_MEMFD : 0);
        virt_map(vm, gva, gpa, test_config.test_num_pages);
@@ -213,14 +223,18 @@ static void __test_pre_fault_memory(enum vm_guest_mode 
guest_mode, void *arg)
        if (p->private)
                vm_mem_set_private(vm, gpa, test_config.test_size);
 
-       pre_fault_memory(vcpu, gpa, 0, test_config.test_size, 0, p->private);
+       pre_fault_memory(vcpu, gpa, 0, test_config.test_size, 0,
+                        p->mem_backing_src, p->private);
        /* Retry the same range after the first prefault attempt. */
-       pre_fault_memory(vcpu, gpa, 0, test_config.test_size, 0, p->private);
+       pre_fault_memory(vcpu, gpa, 0, test_config.test_size, 0,
+                        p->mem_backing_src, p->private);
        pre_fault_memory(vcpu, gpa,
                         test_config.test_size - host_page_size,
-                        host_page_size * 2, host_page_size, p->private);
+                        host_page_size * 2, host_page_size,
+                        p->mem_backing_src, p->private);
        pre_fault_memory(vcpu, gpa, test_config.test_size,
-                        host_page_size, host_page_size, p->private);
+                        host_page_size, host_page_size,
+                        p->mem_backing_src, p->private);
 
        vcpu_args_set(vcpu, 1, gva);
 
@@ -249,11 +263,13 @@ static void __test_pre_fault_memory(enum vm_guest_mode 
guest_mode, void *arg)
        kvm_vm_free(vm);
 }
 
-static void test_pre_fault_memory(unsigned long vm_type, bool private)
+static void test_pre_fault_memory(unsigned long vm_type, enum 
vm_mem_backing_src_type backing_src,
+                                 bool private)
 {
        struct test_params p = {
                .vm_type = vm_type,
                .private = private,
+               .mem_backing_src = backing_src,
        };
 
        if (vm_type && !(kvm_check_cap(KVM_CAP_VM_TYPES) & BIT(vm_type))) {
@@ -267,23 +283,28 @@ static void test_pre_fault_memory(unsigned long vm_type, 
bool private)
 static void help(char *name)
 {
        puts("");
-       printf("usage: %s [-h] [-m mode]\n", name);
+       printf("usage: %s [-h] [-m mode] [-s mem-type]\n", name);
        puts("");
        guest_modes_help();
+       backing_src_help("-s");
        puts("");
 }
 
 int main(int argc, char *argv[])
 {
+       enum vm_mem_backing_src_type backing = DEFAULT_VM_MEM_SRC;
        int opt;
 
        guest_modes_append_default();
 
-       while ((opt = getopt(argc, argv, "hm:")) != -1) {
+       while ((opt = getopt(argc, argv, "hm:s:")) != -1) {
                switch (opt) {
                case 'm':
                        guest_modes_cmdline(optarg);
                        break;
+               case 's':
+                       backing = parse_backing_src_type(optarg);
+                       break;
                case 'h':
                default:
                        help(argv[0]);
@@ -293,10 +314,10 @@ int main(int argc, char *argv[])
 
        TEST_REQUIRE(kvm_check_cap(KVM_CAP_PRE_FAULT_MEMORY));
 
-       test_pre_fault_memory(0, false);
+       test_pre_fault_memory(0, backing, false);
 #ifdef __x86_64__
-       test_pre_fault_memory(KVM_X86_SW_PROTECTED_VM, false);
-       test_pre_fault_memory(KVM_X86_SW_PROTECTED_VM, true);
+       test_pre_fault_memory(KVM_X86_SW_PROTECTED_VM, backing, false);
+       test_pre_fault_memory(KVM_X86_SW_PROTECTED_VM, backing, true);
 #endif
        return 0;
 }
-- 
2.43.0


Reply via email to