On 2026/6/14 05:44, Jakub Kicinski wrote: > On Wed, 10 Jun 2026 16:16:48 +0800 Menglong Dong wrote: > > + /* If both rq->vq and fill ring are empty, and then the user submit > > + * all the chunks to the fill ring and check the wake up flag > > + * after xsk_buff_alloc_batch() and before xsk_set_rx_need_wakeup(), > > + * we will lose the chance to wake up the rx napi, so we have to > > + * set the need_wakeup flag here. > > + */ > > TBH all the comments you're adding are harder to understand than the > code itself ;( Please try to phrase them better or just remove them.
Ah, sorry about that. The race condition here is a little hard to describe for me. After the discussion in the V2: https://lore.kernel.org/netdev/[email protected]/ the race condition seems not likely to happen. So I'll remove this part in V3. Thanks! Menglong Dong > >
