On Thu, May 21, 2026 at 03:47:56PM +0530, Disha Goel wrote: > The file_stressor test requires a 30-minute timeout (1800 seconds) due to > its 15-minute runtime plus setup/teardown overhead. This is significantly > longer than the default 45-second timeout used by other filesystem tests. > > Move file_stressor into its own subdirectory (filesystems/file_stressor/) > with a dedicated settings file to isolate its timeout configuration. This > prevents the long timeout from affecting other fast-running tests in the > filesystems/ directory. > > This restructuring follows the pattern used by other selftests with special > requirements and ensures proper timeout handling in CI/CD environments > while maintaining the default 45-second timeout for other filesystem tests. > > Reported-by: kernel test robot <[email protected]> > Closes: https://lore.kernel.org/all/[email protected]/ > Signed-off-by: Disha Goel <[email protected]> > --- > v1 -> v2 > - Add .gitignore file in filesystems/file_stressor/ to ignore compiled binary > - Update filesystems/.gitignore to remove file_stressor entry > > Link to v1: > https://lore.kernel.org/all/[email protected]/ > > tools/testing/selftests/Makefile | 1 + > tools/testing/selftests/filesystems/.gitignore | 1 - > tools/testing/selftests/filesystems/Makefile | 2 +- > .../testing/selftests/filesystems/file_stressor/.gitignore | 2 ++ > tools/testing/selftests/filesystems/file_stressor/Makefile | 6 ++++++ > .../filesystems/{ => file_stressor}/file_stressor.c | 0 > tools/testing/selftests/filesystems/file_stressor/settings | 3 +++ > 7 files changed, 13 insertions(+), 2 deletions(-) > create mode 100644 > tools/testing/selftests/filesystems/file_stressor/.gitignore > create mode 100644 tools/testing/selftests/filesystems/file_stressor/Makefile > rename tools/testing/selftests/filesystems/{ => > file_stressor}/file_stressor.c (100%) > create mode 100644 tools/testing/selftests/filesystems/file_stressor/settings > > diff --git a/tools/testing/selftests/Makefile > b/tools/testing/selftests/Makefile > index 6e59b8f63e41..d87fafc6aef6 100644 > --- a/tools/testing/selftests/Makefile > +++ b/tools/testing/selftests/Makefile > @@ -34,6 +34,7 @@ TARGETS += filesystems > TARGETS += filesystems/binderfs > TARGETS += filesystems/epoll > TARGETS += filesystems/fat > +TARGETS += filesystems/file_stressor > TARGETS += filesystems/overlayfs > TARGETS += filesystems/statmount > TARGETS += filesystems/mount-notify > diff --git a/tools/testing/selftests/filesystems/.gitignore > b/tools/testing/selftests/filesystems/.gitignore > index 64ac0dfa46b7..3c44753914a6 100644 > --- a/tools/testing/selftests/filesystems/.gitignore > +++ b/tools/testing/selftests/filesystems/.gitignore > @@ -2,6 +2,5 @@ > dnotify_test > devpts_pts > fclog > -file_stressor > anon_inode_test > kernfs_test > diff --git a/tools/testing/selftests/filesystems/Makefile > b/tools/testing/selftests/filesystems/Makefile > index 85427d7f19b9..7d342755aa3f 100644 > --- a/tools/testing/selftests/filesystems/Makefile > +++ b/tools/testing/selftests/filesystems/Makefile > @@ -1,7 +1,7 @@ > # SPDX-License-Identifier: GPL-2.0 > > CFLAGS += $(KHDR_INCLUDES) > -TEST_GEN_PROGS := devpts_pts file_stressor anon_inode_test kernfs_test fclog > +TEST_GEN_PROGS := devpts_pts anon_inode_test kernfs_test fclog > TEST_GEN_PROGS_EXTENDED := dnotify_test > > include ../lib.mk > diff --git a/tools/testing/selftests/filesystems/file_stressor/.gitignore > b/tools/testing/selftests/filesystems/file_stressor/.gitignore > new file mode 100644 > index 000000000000..1eb3f40077d3 > --- /dev/null > +++ b/tools/testing/selftests/filesystems/file_stressor/.gitignore > @@ -0,0 +1,2 @@ > +# SPDX-License-Identifier: GPL-2.0-only > +file_stressor > diff --git a/tools/testing/selftests/filesystems/file_stressor/Makefile > b/tools/testing/selftests/filesystems/file_stressor/Makefile > new file mode 100644 > index 000000000000..88c8231ac144 > --- /dev/null > +++ b/tools/testing/selftests/filesystems/file_stressor/Makefile > @@ -0,0 +1,6 @@ > +# SPDX-License-Identifier: GPL-2.0 > + > +CFLAGS += $(KHDR_INCLUDES) > +TEST_GEN_PROGS := file_stressor > + > +include ../../lib.mk > diff --git a/tools/testing/selftests/filesystems/file_stressor.c > b/tools/testing/selftests/filesystems/file_stressor/file_stressor.c > similarity index 100% > rename from tools/testing/selftests/filesystems/file_stressor.c > rename to tools/testing/selftests/filesystems/file_stressor/file_stressor.c > diff --git a/tools/testing/selftests/filesystems/file_stressor/settings > b/tools/testing/selftests/filesystems/file_stressor/settings > new file mode 100644 > index 000000000000..b675ca93f936 > --- /dev/null > +++ b/tools/testing/selftests/filesystems/file_stressor/settings > @@ -0,0 +1,3 @@ > +# Timeout for file_stressor test > +# The test runs for 900 seconds (15 minutes) plus setup/teardown time > +timeout=1800 > --
Look good to me Disha. I hope you've tested this on the setup where its failing to confirm we are able to reliably pass with the patch. Other than that, feel free to add: Reviewed-by: Ojaswin Mujoo <[email protected]> Regards, Ojaswin > 2.45.1 >
