On Sun, Jun 14, 2026 at 05:07:59PM -0700, Paul Sajna wrote: > Document how to use lg,sw49410-lh609qh1 in a devicetree
"Add Foo bar MIPI DSI panel, which suppors somehing something resolution etc." You describe hardware. > > Signed-off-by: Paul Sajna <[email protected]> > --- > .../bindings/display/panel/lg,sw49410.yaml | 79 > ++++++++++++++++++++++ > 1 file changed, 79 insertions(+) > A nit, subject: drop second/last, redundant "documentation for". The "dt-bindings" prefix is already stating that this is documentation. See also: https://elixir.bootlin.com/linux/v7.1-rc7/source/Documentation/devicetree/bindings/submitting-patches.rst#L23 > diff --git a/Documentation/devicetree/bindings/display/panel/lg,sw49410.yaml > b/Documentation/devicetree/bindings/display/panel/lg,sw49410.yaml > new file mode 100644 > index 000000000000..4c4bf4d89353 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/lg,sw49410.yaml > @@ -0,0 +1,79 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/panel/lg,sw49410.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: LG LH609QH1 MIPI-DSI panel with SW49410 controller > + > +maintainers: > + - Paul Sajna <[email protected]> > + > +description: > + LG LH609QH1 6.1" 1440x3120 MIPI DSI panel with SW49410 controller found in > LG G7 ThinQ smartphone. Please wrap code according to the preferred limit expressed in Kernel coding style (checkpatch is not a coding style description, but only a tool). However don't wrap blindly (see Kernel coding style). > + > +allOf: > + - $ref: panel-common.yaml# > + > +properties: > + compatible: > + items: > + - const: lg,sw49410 > + - const: lg,sw49410-lh609qh1 This is very confusing - why two compatibles and why same devices - both sw49410 - are compatible with each other? > + > + reg: > + maxItems: 1 > + > + backlight: > + description: Backlight device reference Drop property here, not needed. > + > + reset-gpios: > + description: Reset pin reference > + > + vsp-supply: > + description: Positive voltage supply > + > + vsn-supply: > + description: Negative voltage supply > + > +required: > + - compatible > + - reg > + - reset-gpios > + - port > + - vsp-supply > + - vsn-supply > + > +unevaluatedProperties: false > + > +examples: > + - | > + #include <dt-bindings/gpio/gpio.h> > + > + dsi { > + #address-cells = <1>; > + #size-cells = <0>; > + > + panel@0 { > + reg = <0>; > + compatible = "lg,sw49410-lh609qh1"; > + > + backlight = <&pmi8998_wled>; > + reset-gpios = <&tlmm 6 GPIO_ACTIVE_LOW>; > + width-mm = <65>; > + height-mm = <140>; > + > + vsp-supply = <&lab>; > + vsn-supply = <&ibb>; > + > + pinctrl-0 = <&sde_dsi_active &sde_te_active_sleep>; > + pinctrl-1 = <&sde_dsi_sleep &sde_te_active_sleep>; > + pinctrl-names = "default", "sleep"; > + > + port { > + panel_in: endpoint { Messed/inconsistent indentation. Best regards, Krzysztof
