Hi;
10 Şub 2008 Paz tarihinde, Richard Knutsson şunları yazmıştı:
> S.Çağlar Onur wrote:
> > Hi;
> >
> > Following patch silents
> >
> > net/bluetooth/hci_sysfs.c: In function `del_conn':
> > net/bluetooth/hci_sysfs.c:339: warning: suggest parentheses around
> > assignment used as truth value
> >
> > compiler warning introduced by commit
> > acea6852f32b8805e166d885ed7e9f0c7cd10d41 ([BLUETOOTH]: Move children of
> > connection device to NULL before connection down.)
> >
> > Signed-off-by: S.Çağlar Onur <[EMAIL PROTECTED]>
> >
> > net/bluetooth/hci_sysfs.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/net/bluetooth/hci_sysfs.c b/net/bluetooth/hci_sysfs.c
> > index e13cf5e..d2d1e4f 100644
> > --- a/net/bluetooth/hci_sysfs.c
> > +++ b/net/bluetooth/hci_sysfs.c
> > @@ -336,7 +336,7 @@ static void del_conn(struct work_struct *work)
> > struct device *dev;
> > struct hci_conn *conn = container_of(work, struct hci_conn, work);
> >
> > - while (dev = device_find_child(&conn->dev, NULL, __match_tty)) {
> > + while ((dev = device_find_child(&conn->dev, NULL, __match_tty)) !=
> > NULL) {
> >
> Why do you need '!= NULL'?
I thought its more readable than
while ((dev = device_find_child(&conn->dev, NULL, __match_tty))) {
Cheers
--
S.Çağlar Onur <[EMAIL PROTECTED]>
http://cekirdek.pardus.org.tr/~caglar/
Linux is like living in a teepee. No Windows, no Gates and an Apache in house!
signature.asc
Description: This is a digitally signed message part.
