Re: [PATCH] drm: Consistently define pci_device_ids using named initializers

[The Capable Hub]

Hallo Thomas,

On Wed, Jun 17, 2026 at 11:11:32AM +0200, Thomas Zimmermann wrote:
> Am 12.06.26 um 14:10 schrieb Thomas Zimmermann:
> > Hi
> > 
> > Am 04.05.26 um 17:05 schrieb Uwe Kleine-König (The Capable Hub):
> > > The .driver_data member of the various struct pci_device_id arrays were
> > > initialized by list expressions. This isn't easily readable if you're
> > > not into PCI. Using the PCI_DEVICE macro and named initializers is more
> > > explicit and thus easier to parse. Also skip explicit assignments of 0
> > > (which the compiler then takes care of).
> > > 
> > > This change doesn't introduce changes to the compiled pci_device_id
> > > arrays. Tested on x86 and arm64.
> > > 
> > > Signed-off-by: Uwe Kleine-König (The Capable Hub)
> > > <u.kleine-koe...@baylibre.com>
> > 
> > Reviewed-by: Thomas Zimmermann <tzimmerm...@suse.de>
> > 
> > I'll merge the patch into drm-misc-next.
> 
> Merged with a minor change to coding style in gma500.

Ah, you removed spaces from expressions like:

        (long) &cdv_chip_ops

That's fine, thank you.

Best regards
Uwe

signature.asc
Description: PGP signature