[PATCH 1/4] remoteproc: qcom: Fix glink->node reference leak in qcom_add_glink_subdev

[Uday Khare]

In qcom_add_glink_subdev(), the device node reference acquired via
of_get_child_by_name() is stored in glink->node. If the subsequent
kstrdup_const() allocation for glink->ssr_name fails, the function
returns early without calling of_node_put() on glink->node, leaking
the reference count.

Fix this by adding of_node_put(glink->node) on the error path before
returning.

Fixes: cd9fc8f1b35b ("remoteproc: qcom: Pass ssr_name to glink subdevice")
Signed-off-by: Uday Khare <udaykhar...@gmail.com>
---
 drivers/remoteproc/qcom_common.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/remoteproc/qcom_common.c b/drivers/remoteproc/qcom_common.c
index fd2b6824ad26..8af90d4bdbdf 100644
--- a/drivers/remoteproc/qcom_common.c
+++ b/drivers/remoteproc/qcom_common.c
@@ -247,8 +247,10 @@ void qcom_add_glink_subdev(struct rproc *rproc, struct 
qcom_rproc_glink *glink,
                return;
 
        glink->ssr_name = kstrdup_const(ssr_name, GFP_KERNEL);
-       if (!glink->ssr_name)
+       if (!glink->ssr_name) {
+               of_node_put(glink->node);
                return;
+       }
 
        glink->dev = dev;
        glink->subdev.start = glink_subdev_start;
-- 
2.54.0