On Tue, Jun 16, 2026 at 08:44:13PM -0400, Emil Tsalapatis wrote: [...] > Can we just prevent a ring from being added with a NULL sample_cb? > What's the use for permitting it?
I kept NULL callbacks valid because I plan to add a caller-owned iterator that does not use callbacks. Rejecting NULL during construction would prevent callers from creating iterator-only rings. > Even if we don't, rechecking the callbacks every single time we > consume the ringbuf seems overkill. Your `unlikely()` suggestion on patch 6 applies here too, so I used it in v2.
