On Mon, Jun 22 2026 at 09:55, David Woodhouse wrote:
> On Fri, 2026-05-29 at 22:01 +0200, Thomas Gleixner wrote:
>> From: Thomas Gleixner <[email protected]>
>>
>> PTP device system crosstime stamps support only CLOCK_REALTIME, which is
>> meaningless for AUX clocks. The PTP core hands in the clock ID already, so
>> prepare the core code to honor it.
>>
>> - Add a new sys_systime field to struct system_device_crosststamp which
>> aliases the sys_realtime field. Once all users are converted
>> sys_realtime can be removed.
>>
>> - Prepare get_device_system_crosststamp() and the related code for it by
>> switching to sys_systime and providing the initial changes to utilize
>> different time keepers.
>>
>> No functional change intended.
>
> We ended up with ktime_get_snapshot_id() also supporting CLOCK_BOOTTIME
> and CLOCK_MONOTONIC_RAW, but not get_device_system_crosststamp().
> Should we make that consistent?
Maybe. The BOOTTIME support is only there for that ARM64 hyper trace muck,
but has no other relevance.
MONORAW is there for the PTP EXTENDED IOCTL, but with PRECISE the
snapshot already contains the raw value and you'd have to prevent the
historical adjustment part for RAW. So I don't see the actual value, but
I don't have a strong opinion either.
Thanks,
tglx
