On Fri, Jun 12, 2026 at 04:49:58PM -0500, Rob Herring (Arm) wrote: > The OMAP and Keystone remoteproc drivers only need to know whether > "ti,bootreg" and "ti,syscon-dev" are present before parsing them. > Reading those properties as booleans misrepresents their DT encoding. > > Use of_property_present() for the presence tests and keep the existing > phandle parsing for the actual property values. > > Assisted-by: Codex:gpt-5-5 > Signed-off-by: Rob Herring (Arm) <[email protected]> > --- > drivers/remoteproc/keystone_remoteproc.c | 2 +- > drivers/remoteproc/omap_remoteproc.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/remoteproc/keystone_remoteproc.c > b/drivers/remoteproc/keystone_remoteproc.c > index e7fde5509786..83763d640c4e 100644 > --- a/drivers/remoteproc/keystone_remoteproc.c > +++ b/drivers/remoteproc/keystone_remoteproc.c > @@ -317,7 +317,7 @@ static int keystone_rproc_of_get_dev_syscon(struct > platform_device *pdev, > struct device_node *np = pdev->dev.of_node; > struct device *dev = &pdev->dev; > > - if (!of_property_read_bool(np, "ti,syscon-dev")) { > + if (!of_property_present(np, "ti,syscon-dev")) { > dev_err(dev, "ti,syscon-dev property is absent\n"); > return -EINVAL; > } > diff --git a/drivers/remoteproc/omap_remoteproc.c > b/drivers/remoteproc/omap_remoteproc.c > index cb01354248af..6ed0f28edac9 100644 > --- a/drivers/remoteproc/omap_remoteproc.c > +++ b/drivers/remoteproc/omap_remoteproc.c > @@ -1140,7 +1140,7 @@ static int omap_rproc_get_boot_data(struct > platform_device *pdev, > if (!data) > return -ENODEV; > > - if (!of_property_read_bool(np, "ti,bootreg")) > + if (!of_property_present(np, "ti,bootreg")) > return 0; >
I'll apply this when rc1 comes out next week. Thanks, Mathieu > oproc->boot_data = devm_kzalloc(&pdev->dev, sizeof(*oproc->boot_data), > -- > 2.53.0 >
