On Wed, 24 Jun 2026 18:02:25 +0200, David Heidelberg wrote:
> Convert CS35L36 Speaker Amplifier to yaml.
>
> Changes:
> - maintainers email to the generic Cirrus email
> - Both the codec and downstream worked just fine without
> VP-supply provided. Align with datasheet for similar models.
> - add dai-common.yaml to cover for '#sound-dai-cells',
> 'sound-name-prefix'
>
> Reviewed-by: David Rhodes <[email protected]>
> Co-developed-by: Rob Herring (Arm) <[email protected]>
> Signed-off-by: Rob Herring (Arm) <[email protected]>
> Signed-off-by: David Heidelberg <[email protected]>
> ---
> Relevant for Pixel 3 / 3XL / 4.
> ---
> Changes in v2:
> - Rename the commit. (Mark)
> - Link to v1:
> https://lore.kernel.org/r/[email protected]
> ---
> .../devicetree/bindings/sound/cirrus,cs35l36.yaml | 224
> +++++++++++++++++++++
> .../devicetree/bindings/sound/cs35l36.txt | 168 ----------------
> 2 files changed, 224 insertions(+), 168 deletions(-)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sound/cirrus,cs35l36.yaml:
properties:cirrus,vpbr-config:type: 'boolean' was expected
hint: A vendor boolean property can use "type: boolean"
from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sound/cirrus,cs35l36.yaml:
Unresolvable reference: /schemas/sound/dai-common.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sound/cirrus,cs35l36.example.dtb:
codec@40 (cirrus,cs35l36): Unevaluated properties are not allowed
('cirrus,weak-fet-delay', 'cirrus,weak-fet-thld' were unexpected)
from schema $id: http://devicetree.org/schemas/cirrus,cs35l36.yaml
doc reference errors (make refcheckdocs):
See
https://patchwork.kernel.org/project/devicetree/patch/[email protected]
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
