On 30/06/2026 15:47, Ben Levinsky wrote:
> Hi Krzysztof,
> 
> I apologize if this came off as my ignoring your emails.
> 
> In the v3 you had said: 
> 
>> +          - enum:
>> +              - xlnx,versal-bram-rproc
>> +              - xlnx,versal-net-bram-rproc
>> +              - amd,versal2-bram-rproc
> 
> If there is going to be a new version, this should be sorted by name.
> 
> Reviewed-by: Krzysztof Kozlowski <[email protected]>
> 
> 
> I was uncomfortable in adding the Reviewed-by if that is what you meant.
> 
> In this v4 I believe your review comment to sort by name was addressed.
> 
> Apologies for my misunderstanding.

Did you implement my comment? It seems yes. Did you change something
else? It seems not, at least changelog is silent. So why would me Review
tag be not appropriate if you actually implemented reviewer's feedback?

Best regards,
Krzysztof

Reply via email to