Hi,
> > #include <sys/types.h>
> > @@ -36,6 +35,10 @@ static pthread_mutex_t mutex = PTHREAD_MUTEX_INITIALIZER;
> > static pthread_cond_t cond = PTHREAD_COND_INITIALIZER;
> > static siginfo_t siginfo = {0};
> >
> > +int iteration_nr = 1;
> > +int test_nr;
> > +int dprint_in_signal;
>
> Might as well define those in pkey_util.c as well (move them in patch 1
> too).
Thanks for the suggestion. I'll move test_nr, iteration_nr and
dprint_in_signal into pkey_util.c in patch 1/5 and drop the duplicate
definitions from protection_keys.c and pkey_sighandler_tests.c.
> > [...]
> >
> > /* Use clone to avoid newer glibcs using rseq on new threads */
> > - long ret = clone_raw(CLONE_VM | CLONE_FS | CLONE_FILES |
> > + ret = clone_raw(CLONE_VM | CLONE_FS | CLONE_FILES |
> > CLONE_SIGHAND | CLONE_THREAD | CLONE_SYSVSEM |
> > CLONE_PARENT_SETTID | CLONE_CHILD_CLEARTID |
> > CLONE_DETACHED,
>
> Align these lines to the opening (.
Thanks for catching that. I'll align the clone_raw() argument lines to
the opening '(' in the next version.
Best regards,
Hongfu
