On 7/5/26 10:06 PM, David Heidelberg via B4 Relay wrote:
> From: David Heidelberg <[email protected]>
>
> Introduce support for sound card and wire two CS35L36 audio codecs for
> top and bottom speakers.
>
> Inspired by commit from Joel Selvaraj.
>
> Signed-off-by: David Heidelberg <[email protected]>
> ---
[...]
> + /* CS35L36, Bottom Speaker */
> + cs35l36_bottom: audio-codec@40 {
> + compatible = "cirrus,cs35l36";
> + reg = <0x40>;
> + reset-gpios = <&tlmm 112 GPIO_ACTIVE_HIGH>;
> + #sound-dai-cells = <0>;
> + sound-name-prefix = "Right"; /* Bottom */
One comment's enough (either above the node or here)
[...]
> + mm1-dai-link {
> + link-name = "MultiMedia1";
> +
> + cpu {
> + sound-dai = <&q6asmdai MSM_FRONTEND_DAI_MULTIMEDIA1>;
> + };
> + };
> +
> + cs35l36-dai-link {
> + link-name = "Speaker Playback";
> +
> + cpu {
> + sound-dai = <&q6afedai QUATERNARY_TDM_RX_0>;
> + };
> +
> + platform {
> + sound-dai = <&q6routing>;
> + };
> +
> + codec {
> + sound-dai = <&cs35l36_bottom>, <&cs35l36_top>;
> + };
nit: 'co'dec < 'cp'u < 'p'latform
also 'c's35l36-dai-link < `m`m1-dai-link
otherwise:
Reviewed-by: Konrad Dybcio <[email protected]>
Konrad
