> The regset_data buffer allocated with calloc() in the parent process > of several vector ptrace tests is never freed before returning, > causing memory leaks in: > > - ptrace_v_not_enabled > - ptrace_v_early_debug > - ptrace_v_syscall_clobbering > - v_csr_invalid/ptrace_v_invalid_values > - v_csr_valid/ptrace_v_valid_values > > Add free(regset_data) before kill(pid, SIGKILL) to release the > allocated buffer. > > Signed-off-by: Wang Yan <[email protected]> > --- > .../testing/selftests/riscv/vector/validate_v_ptrace.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/tools/testing/selftests/riscv/vector/validate_v_ptrace.c > b/tools/testing/selftests/riscv/vector/validate_v_ptrace.c > index b038e2175c80..a388b7963d47 100644 > --- a/tools/testing/selftests/riscv/vector/validate_v_ptrace.c > +++ b/tools/testing/selftests/riscv/vector/validate_v_ptrace.c > @@ -75,7 +75,7 @@ TEST(ptrace_v_not_enabled) > ASSERT_EQ(-1, ret); > > /* cleanup */ > - > + free(regset_data); > ASSERT_EQ(0, kill(pid, SIGKILL)); > } > } > @@ -207,7 +207,7 @@ TEST(ptrace_v_early_debug) > EXPECT_EQ(vl_csr, regset_data->vl); > > /* cleanup */ > - > + free(regset_data); > ASSERT_EQ(0, kill(pid, SIGKILL)); > } > } > @@ -331,7 +331,7 @@ TEST(ptrace_v_syscall_clobbering) > EXPECT_EQ(0UL, regset_data->vl); > > /* cleanup */ > - > + free(regset_data); > ASSERT_EQ(0, kill(pid, SIGKILL)); > } > } > @@ -649,7 +649,7 @@ TEST_F(v_csr_invalid, ptrace_v_invalid_values) > ASSERT_EQ(ret, -1); > > /* cleanup */ > - > + free(regset_data); > ASSERT_EQ(0, kill(pid, SIGKILL)); > } > } > @@ -911,7 +911,7 @@ TEST_F(v_csr_valid, ptrace_v_valid_values) > EXPECT_EQ(regset_data->vlenb, vlenb); > > /* cleanup */ > - > + free(regset_data); > ASSERT_EQ(0, kill(pid, SIGKILL)); > } > }
Thanks ! Reviewed-by: Sergey Matyukevich <[email protected]> Regards, Sergey
