On Fri, Jul 10, 2026 at 06:53:07PM +0800, Pan Chuang wrote:
> Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
> devm_request_*_irq()"), devm_request_irq() automatically logs
> detailed error messages on failure. Remove the now-redundant
> driver-specific dev_err() calls.
>
> Signed-off-by: Pan Chuang <[email protected]>
Reviewed-by: Jarkko Sakkinen <[email protected]>
Applied:
https://git.kernel.org/pub/scm/linux/kernel/git/jarkko/linux-tpmdd.git/log/
> ---
> drivers/char/tpm/st33zp24/st33zp24.c | 5 +----
> drivers/char/tpm/tpm_i2c_nuvoton.c | 2 --
> drivers/char/tpm/tpm_tis_i2c_cr50.c | 4 +---
> 3 files changed, 2 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/char/tpm/st33zp24/st33zp24.c
> b/drivers/char/tpm/st33zp24/st33zp24.c
> index e2b7451ea7cc..8d5179367eac 100644
> --- a/drivers/char/tpm/st33zp24/st33zp24.c
> +++ b/drivers/char/tpm/st33zp24/st33zp24.c
> @@ -506,11 +506,8 @@ int st33zp24_probe(void *phy_id, const struct
> st33zp24_phy_ops *ops,
> ret = devm_request_irq(dev, irq, tpm_ioserirq_handler,
> IRQF_TRIGGER_HIGH, "TPM SERIRQ management",
> chip);
> - if (ret < 0) {
> - dev_err(&chip->dev, "TPM SERIRQ signals %d not
> available\n",
> - irq);
> + if (ret < 0)
> goto _tpm_clean_answer;
> - }
>
> intmask |= TPM_INTF_CMD_READY_INT
> | TPM_INTF_STS_VALID_INT
> diff --git a/drivers/char/tpm/tpm_i2c_nuvoton.c
> b/drivers/char/tpm/tpm_i2c_nuvoton.c
> index aa3673002f3a..c84afb29d548 100644
> --- a/drivers/char/tpm/tpm_i2c_nuvoton.c
> +++ b/drivers/char/tpm/tpm_i2c_nuvoton.c
> @@ -576,8 +576,6 @@ static int i2c_nuvoton_probe(struct i2c_client *client)
> dev_name(&chip->dev),
> chip);
> if (rc) {
> - dev_err(dev, "%s() Unable to request irq: %d for use\n",
> - __func__, priv->irq);
> priv->irq = 0;
> } else {
> chip->flags |= TPM_CHIP_FLAG_IRQ;
> diff --git a/drivers/char/tpm/tpm_tis_i2c_cr50.c
> b/drivers/char/tpm/tpm_tis_i2c_cr50.c
> index b48cacacc066..7f828fae70d3 100644
> --- a/drivers/char/tpm/tpm_tis_i2c_cr50.c
> +++ b/drivers/char/tpm/tpm_tis_i2c_cr50.c
> @@ -751,10 +751,8 @@ static int tpm_cr50_i2c_probe(struct i2c_client *client)
> rc = devm_request_irq(dev, client->irq,
> tpm_cr50_i2c_int_handler,
> IRQF_TRIGGER_FALLING | IRQF_NO_AUTOEN,
> dev->driver->name, chip);
> - if (rc < 0) {
> - dev_err(dev, "Failed to probe IRQ %d\n", client->irq);
> + if (rc < 0)
> return rc;
> - }
>
> priv->irq = client->irq;
> } else {
> --
> 2.34.1
>
BR, Jarkko
