On Wed, Jul 15, 2026 at 01:35:52PM +0800, Kuan-Ying Lee wrote:
> We hit the following build error while running the seccomp selftests in
> our testing.
> 
> CC seccomp_bpf
> seccomp_bpf.c: In function ‘UPROBE_setup’:
> seccomp_bpf.c:5175:74: error: pointer type mismatch in conditional expression 
> [-Wincompatible-pointer-types]
> 5175 | offset = get_uprobe_offset(variant->uretprobe ? probed_uretprobe : 
> probed_uprobe);
> | ^
> seccomp_bpf.c:5175:57: note: first expression has type ‘int (*)(void)’
> 5175 | offset = get_uprobe_offset(variant->uretprobe ? probed_uretprobe : 
> probed_uprobe);
> | ^~~~~~~~~~~~~~~~
> seccomp_bpf.c:5175:76: note: second expression has type ‘int 
> (__attribute__((nocf_check)) *)(void)’
> 5175 | offset = get_uprobe_offset(variant->uretprobe ? probed_uretprobe : 
> probed_uprobe);
> | ^~~~~~~~~~~~~
> 
> get_uprobe_offset() takes a 'const void *' argument, so cast both
> operands to 'void *'.
> 
> Fixes: 9ffc7a635c35 ("selftests/seccomp: validate uprobe syscall passes 
> through seccomp")
> Signed-off-by: Kuan-Ying Lee <[email protected]>

Acked-by: Jiri Olsa <[email protected]>

thanks,
jirka


> ---
>  tools/testing/selftests/seccomp/seccomp_bpf.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/seccomp/seccomp_bpf.c 
> b/tools/testing/selftests/seccomp/seccomp_bpf.c
> index 358b6c65e120..0622bc2acad4 100644
> --- a/tools/testing/selftests/seccomp/seccomp_bpf.c
> +++ b/tools/testing/selftests/seccomp/seccomp_bpf.c
> @@ -5178,7 +5178,8 @@ FIXTURE_SETUP(UPROBE)
>               ASSERT_GE(bit, 0);
>       }
>  
> -     offset = get_uprobe_offset(variant->uretprobe ? probed_uretprobe : 
> probed_uprobe);
> +     offset = get_uprobe_offset(variant->uretprobe ? (void *)probed_uretprobe
> +                                                   : (void *)probed_uprobe);
>       ASSERT_GE(offset, 0);
>  
>       if (variant->uretprobe)
> -- 
> 2.43.0
> 

Reply via email to