> selftests/bpf: Test bpf_strcat,bpf_strncat kfuncs
>
> Add tests for new kfuncs bpf_strcat() and bpf_strncat().
>
> And remove extra whitespaces in selftests string_kfuncs_failure1.c.
>
> Signed-off-by: Rong Tao <[email protected]>
This isn't a bug, but could the whitespace cleanup in
string_kfuncs_failure1.c be split into its own patch rather than folded
into the commit that adds the strcat/strncat tests? The commit message
already describes them as two separate changes, and the whitespace-only
churn ends up mixed in with the new test cases:
> diff --git a/tools/testing/selftests/bpf/progs/string_kfuncs_failure1.c
> b/tools/testing/selftests/bpf/progs/string_kfuncs_failure1.c
> index bddc4e8579d2..d432d4990f80 100644
> --- a/tools/testing/selftests/bpf/progs/string_kfuncs_failure1.c
> +++ b/tools/testing/selftests/bpf/progs/string_kfuncs_failure1.c
[ ... ]
> @@ -30,29 +31,31 @@ char *invalid_kern_ptr = (char *)-1;
>
> /* Passing NULL to string kfuncs (treated as a userspace ptr) */
> SEC("syscall") __retval(USER_PTR_ERR) int test_strcmp_null1(void *ctx) {
> return bpf_strcmp(NULL, "hello"); }
> -SEC("syscall") __retval(USER_PTR_ERR)int test_strcmp_null2(void *ctx) {
> return bpf_strcmp("hello", NULL); }
> +SEC("syscall") __retval(USER_PTR_ERR)int test_strcmp_null2(void *ctx) {
> return bpf_strcmp("hello", NULL); }
> SEC("syscall") __retval(USER_PTR_ERR) int test_strcasecmp_null1(void *ctx) {
> return bpf_strcasecmp(NULL, "HELLO"); }
> -SEC("syscall") __retval(USER_PTR_ERR)int test_strcasecmp_null2(void *ctx) {
> return bpf_strcasecmp("HELLO", NULL); }
> +SEC("syscall") __retval(USER_PTR_ERR)int test_strcasecmp_null2(void *ctx) {
> return bpf_strcasecmp("HELLO", NULL); }
[ ... ]
> +SEC("syscall") __retval(USER_PTR_ERR)int test_strcat_null1(void *ctx) {
> return bpf_strcat(kern_buf, sizeof(kern_buf), NULL); }
> +SEC("syscall") __retval(USER_PTR_ERR)int test_strncat_null1(void *ctx) {
> return bpf_strncat(kern_buf, sizeof(kern_buf), NULL, 2); }
Keeping the two apart would make the new test additions easier to read on
their own.
---
AI reviewed your patch. Please fix the bug or email reply why it's not a bug.
See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md
CI run summary: https://github.com/kernel-patches/bpf/actions/runs/29729113722
