On Tue, Jul 21, 2026 at 11:59:02AM +0530, Gaurav Kohli wrote:
> Unlike the CPU, the CDSP/Modem does not throttle its speed automatically
> when it reaches high temperatures in kodiak.
> 
> Set up CDSP cooling by throttling the cdsp when it reaches 100°C and
> for modem when it reaches to 95°C.
> 
> Add polling-delay-passive so the governor periodically evaluates
> the zone during passive cooling and steps up cooling levels when
> temperature stabilizes below the next trip.
> 
> Since the remoteproc_mpss node doesn't exist on non modem boards, the
> cooling-maps that reference it cause DT compilation errors. To fix that
> remove inherited mdmss cooling-map nodes.
> 
> Signed-off-by: Gaurav Kohli <[email protected]>
> ---
>  arch/arm64/boot/dts/qcom/kodiak.dtsi               | 134 
> ++++++++++++++++++++-
>  .../boot/dts/qcom/qcs6490-radxa-dragon-q6a.dts     |  29 +++++
>  arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts       |   1 +
>  .../dts/qcom/qcs6490-thundercomm-minipc-g1iot.dts  |  29 +++++
>  .../boot/dts/qcom/qcs6490-thundercomm-rubikpi3.dts |  29 +++++
>  .../boot/dts/qcom/qcs6490-vicharak-axon-mini.dts   |  29 +++++
>  .../boot/dts/qcom/sc7280-herobrine-lte-sku.dtsi    |  29 +++++
>  .../boot/dts/qcom/sc7280-herobrine-wifi-sku.dtsi   |  28 +++++
>  8 files changed, 304 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/kodiak.dtsi 
> b/arch/arm64/boot/dts/qcom/kodiak.dtsi
> index 7e73348fe0d0..df5099023b77 100644
> --- a/arch/arm64/boot/dts/qcom/kodiak.dtsi
> +++ b/arch/arm64/boot/dts/qcom/kodiak.dtsi
> @@ -30,6 +30,7 @@
>  #include <dt-bindings/sound/qcom,lpass.h>
>  #include <dt-bindings/sound/qcom,q6afe.h>
>  #include <dt-bindings/sound/qcom,q6asm.h>
> +#include <dt-bindings/thermal/qcom,qmi-tmd.h>
>  #include <dt-bindings/thermal/thermal.h>
>  
>  / {
> @@ -3431,6 +3432,8 @@ remoteproc_mpss: remoteproc@4080000 {
>                       qcom,smem-states = <&modem_smp2p_out 0>;
>                       qcom,smem-state-names = "stop";
>  
> +                     #cooling-cells = <3>;
> +
>                       status = "disabled";
>  
>                       glink-edge {
> @@ -4803,6 +4806,8 @@ remoteproc_cdsp: remoteproc@a300000 {
>                       qcom,smem-states = <&cdsp_smp2p_out 0>;
>                       qcom,smem-state-names = "stop";
>  
> +                     #cooling-cells = <3>;
> +
>                       status = "disabled";
>  
>                       glink-edge {
> @@ -4922,6 +4927,7 @@ compute-cb@14 {
>                                       };
>                               };
>                       };
> +

Extra empty line.

>               };
>  
>               usb_1: usb@a600000 {
> @@ -7732,6 +7738,8 @@ map0 {
>               };
>  
>               nspss0-thermal {
> +                     polling-delay-passive = <200>;
> +
>                       thermal-sensors = <&tsens1 3>;
>  
>                       trips {
> @@ -7741,15 +7749,31 @@ nspss0_alert0: trip-point0 {
>                                       type = "hot";
>                               };
>  
> +                             nspss0_alert1: trip-point1 {
> +                                     temperature = <100000>;
> +                                     hysteresis = <5000>;
> +                                     type = "passive";
> +                             };
> +
>                               nspss0_crit: nspss0-crit {
>                                       temperature = <110000>;
>                                       hysteresis = <0>;
>                                       type = "critical";
>                               };
>                       };
> +
> +                     cooling-maps {
> +                             map0 {
> +                                     trip = <&nspss0_alert1>;
> +                                     cooling-device = <&remoteproc_cdsp 
> QCOM_TMD_CDSP_SW
> +                                                      THERMAL_NO_LIMIT 
> THERMAL_NO_LIMIT>;
> +                             };
> +                     };
>               };
>  
>               nspss1-thermal {
> +                     polling-delay-passive = <200>;
> +
>                       thermal-sensors = <&tsens1 4>;
>  
>                       trips {
> @@ -7759,12 +7783,26 @@ nspss1_alert0: trip-point0 {
>                                       type = "hot";
>                               };
>  
> +                             nspss1_alert1: trip-point1 {
> +                                     temperature = <100000>;
> +                                     hysteresis = <5000>;
> +                                     type = "passive";
> +                             };
> +
>                               nspss1_crit: nspss1-crit {
>                                       temperature = <110000>;
>                                       hysteresis = <0>;
>                                       type = "critical";
>                               };
>                       };
> +
> +                     cooling-maps {
> +                             map0 {
> +                                     trip = <&nspss1_alert1>;
> +                                     cooling-device = <&remoteproc_cdsp 
> QCOM_TMD_CDSP_SW
> +                                                      THERMAL_NO_LIMIT 
> THERMAL_NO_LIMIT>;
> +                             };
> +                     };
>               };
>  
>               video-thermal {
> @@ -7803,7 +7841,9 @@ ddr_crit: ddr-crit {
>                       };
>               };
>  
> -             mdmss0-thermal {
> +             mdmss0_thermal: mdmss0-thermal {
> +                     polling-delay-passive = <200>;
> +
>                       thermal-sensors = <&tsens1 7>;
>  
>                       trips {
> @@ -7813,15 +7853,37 @@ mdmss0_alert0: trip-point0 {
>                                       type = "hot";
>                               };
>  
> +                             mdmss0_alert1: trip-point1 {
> +                                     temperature = <95000>;
> +                                     hysteresis = <2000>;
> +                                     type = "passive";
> +                             };
> +
>                               mdmss0_crit: mdmss0-crit {
>                                       temperature = <110000>;
>                                       hysteresis = <0>;
>                                       type = "critical";
>                               };
>                       };
> +
> +                     cooling-maps {
> +                             map0 {
> +                                     trip = <&mdmss0_alert1>;
> +                                     cooling-device = <&remoteproc_mpss 
> QCOM_TMD_PA
> +                                                      THERMAL_NO_LIMIT 
> THERMAL_NO_LIMIT>;
> +                             };
> +
> +                             map1 {
> +                                     trip = <&mdmss0_alert1>;
> +                                     cooling-device = <&remoteproc_mpss 
> QCOM_TMD_MODEM
> +                                                      THERMAL_NO_LIMIT 
> THERMAL_NO_LIMIT>;
> +                             };
> +                     };
>               };
>  
> -             mdmss1-thermal {
> +             mdmss1_thermal: mdmss1-thermal {
> +                     polling-delay-passive = <200>;
> +
>                       thermal-sensors = <&tsens1 8>;
>  
>                       trips {
> @@ -7831,15 +7893,37 @@ mdmss1_alert0: trip-point0 {
>                                       type = "hot";
>                               };
>  
> +                             mdmss1_alert1: trip-point1 {
> +                                     temperature = <95000>;
> +                                     hysteresis = <2000>;
> +                                     type = "passive";
> +                             };
> +
>                               mdmss1_crit: mdmss1-crit {
>                                       temperature = <110000>;
>                                       hysteresis = <0>;
>                                       type = "critical";
>                               };
>                       };
> +
> +                     cooling-maps {
> +                             map0 {
> +                                     trip = <&mdmss1_alert1>;
> +                                     cooling-device = <&remoteproc_mpss 
> QCOM_TMD_PA
> +                                                      THERMAL_NO_LIMIT 
> THERMAL_NO_LIMIT>;
> +                             };
> +
> +                             map1 {
> +                                     trip = <&mdmss1_alert1>;
> +                                     cooling-device = <&remoteproc_mpss 
> QCOM_TMD_MODEM
> +                                                      THERMAL_NO_LIMIT 
> THERMAL_NO_LIMIT>;
> +                             };
> +                     };
>               };
>  
> -             mdmss2-thermal {
> +             mdmss2_thermal: mdmss2-thermal {
> +                     polling-delay-passive = <200>;
> +
>                       thermal-sensors = <&tsens1 9>;
>  
>                       trips {
> @@ -7849,15 +7933,37 @@ mdmss2_alert0: trip-point0 {
>                                       type = "hot";
>                               };
>  
> +                             mdmss2_alert1: trip-point1 {
> +                                     temperature = <95000>;
> +                                     hysteresis = <2000>;
> +                                     type = "passive";
> +                             };
> +
>                               mdmss2_crit: mdmss2-crit {
>                                       temperature = <110000>;
>                                       hysteresis = <0>;
>                                       type = "critical";
>                               };
>                       };
> +
> +                     cooling-maps {
> +                             map0 {
> +                                     trip = <&mdmss2_alert1>;
> +                                     cooling-device = <&remoteproc_mpss 
> QCOM_TMD_PA
> +                                                      THERMAL_NO_LIMIT 
> THERMAL_NO_LIMIT>;
> +                             };
> +
> +                             map1 {
> +                                     trip = <&mdmss2_alert1>;
> +                                     cooling-device = <&remoteproc_mpss 
> QCOM_TMD_MODEM
> +                                                      THERMAL_NO_LIMIT 
> THERMAL_NO_LIMIT>;
> +                             };
> +                     };
>               };
>  
> -             mdmss3-thermal {
> +             mdmss3_thermal: mdmss3-thermal {
> +                     polling-delay-passive = <200>;
> +
>                       thermal-sensors = <&tsens1 10>;
>  
>                       trips {
> @@ -7867,12 +7973,32 @@ mdmss3_alert0: trip-point0 {
>                                       type = "hot";
>                               };
>  
> +                             mdmss3_alert1: trip-point1 {
> +                                     temperature = <95000>;
> +                                     hysteresis = <2000>;
> +                                     type = "passive";
> +                             };
> +
>                               mdmss3_crit: mdmss3-crit {
>                                       temperature = <110000>;
>                                       hysteresis = <0>;
>                                       type = "critical";
>                               };
>                       };
> +
> +                     cooling-maps {
> +                             map0 {
> +                                     trip = <&mdmss3_alert1>;
> +                                     cooling-device = <&remoteproc_mpss 
> QCOM_TMD_PA
> +                                                      THERMAL_NO_LIMIT 
> THERMAL_NO_LIMIT>;
> +                             };
> +
> +                             map1 {
> +                                     trip = <&mdmss3_alert1>;
> +                                     cooling-device = <&remoteproc_mpss 
> QCOM_TMD_MODEM
> +                                                      THERMAL_NO_LIMIT 
> THERMAL_NO_LIMIT>;
> +                             };
> +                     };
>               };
>  
>               camera0-thermal {
> diff --git a/arch/arm64/boot/dts/qcom/qcs6490-radxa-dragon-q6a.dts 
> b/arch/arm64/boot/dts/qcom/qcs6490-radxa-dragon-q6a.dts
> index 82ebd88f9aba..befd3f908ce5 100644
> --- a/arch/arm64/boot/dts/qcom/qcs6490-radxa-dragon-q6a.dts
> +++ b/arch/arm64/boot/dts/qcom/qcs6490-radxa-dragon-q6a.dts
> @@ -24,6 +24,35 @@
>  /delete-node/ &adsp_mem;
>  /delete-node/ &cdsp_mem;
>  /delete-node/ &ipa_fw_mem;
> +
> +&mdmss0_thermal {
> +     cooling-maps {
> +             /delete-node/ map0;
> +             /delete-node/ map1;
> +     };
> +};
> +
> +&mdmss1_thermal {
> +     cooling-maps {
> +             /delete-node/ map0;
> +             /delete-node/ map1;
> +     };
> +};
> +
> +&mdmss2_thermal {
> +     cooling-maps {
> +             /delete-node/ map0;
> +             /delete-node/ map1;
> +     };
> +};
> +
> +&mdmss3_thermal {
> +     cooling-maps {
> +             /delete-node/ map0;
> +             /delete-node/ map1;
> +     };
> +};

This is out of place. If you want to remove maps, remove them directly
by label, rather than deleting them through a path under a thermal node.

> +
>  /delete-node/ &mpss_mem;
>  /delete-node/ &remoteproc_mpss;
>  /delete-node/ &remoteproc_wpss;
> diff --git a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts 
> b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
> index e9a932c90d14..48751bc2265d 100644
> --- a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
> +++ b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
> @@ -25,6 +25,7 @@
>  /delete-node/ &rmtfs_mem;
>  /delete-node/ &adsp_mem;
>  /delete-node/ &cdsp_mem;
> +

Why?

>  /delete-node/ &video_mem;
>  /delete-node/ &wlan_ce_mem;
>  /delete-node/ &wpss_mem;

-- 
With best wishes
Dmitry

Reply via email to