The test relies on the numeric values of the clockids.
As not all clocks are meant to be tested, this requires skipping some
clocks unconditionally, cluttering the result.

Use an equivalent, explicit list instead.

Signed-off-by: Thomas Weißschuh (Schneider Electric) 
<[email protected]>
---
 tools/testing/selftests/timers/nsleep-lat.c | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/tools/testing/selftests/timers/nsleep-lat.c 
b/tools/testing/selftests/timers/nsleep-lat.c
index d46f17404439..ead3271287d6 100644
--- a/tools/testing/selftests/timers/nsleep-lat.c
+++ b/tools/testing/selftests/timers/nsleep-lat.c
@@ -29,9 +29,6 @@
 
 #define UNRESONABLE_LATENCY (40 * NSEC_PER_MSEC)
 
-/* CLOCK_HWSPECIFIC == CLOCK_SGI_CYCLE (Deprecated) */
-#define CLOCK_HWSPECIFIC               10
-
 #define UNSUPPORTED 0xf00f
 
 struct timespec timespec_add(struct timespec ts, unsigned long long ns)
@@ -103,18 +100,21 @@ int main(int argc, char **argv)
 {
        long long length;
        int clockid, ret;
-       int max_clocks = CLOCK_TAI + 1;
 
-       ksft_print_header();
-       ksft_set_plan(max_clocks - CLOCK_REALTIME - SKIPPED_CLOCK_COUNT);
+       static const clockid_t tested_clocks[] = {
+               CLOCK_REALTIME,
+               CLOCK_MONOTONIC,
+               CLOCK_BOOTTIME,
+               CLOCK_BOOTTIME_ALARM,
+               CLOCK_REALTIME_ALARM,
+               CLOCK_TAI,
+       };
 
-       for (clockid = CLOCK_REALTIME; clockid < max_clocks; clockid++) {
+       ksft_print_header();
+       ksft_set_plan(ARRAY_SIZE(tested_clocks));
 
-               /* Skip cputime clockids since nanosleep won't increment 
cputime */
-               if (clockid == CLOCK_PROCESS_CPUTIME_ID ||
-                               clockid == CLOCK_THREAD_CPUTIME_ID ||
-                               clockid == CLOCK_HWSPECIFIC)
-                       continue;
+       for (size_t clock_index = 0; clock_index < ARRAY_SIZE(tested_clocks); 
clock_index++) {
+               clockid = tested_clocks[clock_index];
 
                length = 10;
                while (length <= (NSEC_PER_SEC * 10)) {

-- 
2.55.0


Reply via email to