The ipv6_flowlabel_mgr test file was lacking coverage for the IPV6_FL_A_RENEW action, and the IPV6_FL_F_REMOTE and IPV6_FL_F_REFLECT flags. The first two patches from this set aim to add a proper test case for RENEW and REMOTE.
The third patch was added to insert network namespace creation inside the test suite, instead of relying on external wrapper scripts. This change conforms to other net test implementations, such as tools/testing/selftests/net/icmp_rfc4884.c, and it is important for the fourth and fifth patches. The fourth patch adds the IPV6_FL_F_REFLECT test. The fifth patch proposes the adoption of "kselftest_harness.h" helpers, improving code readability and conforming to the implementation of the most recent selftests. --- v3: - Remove unused FL_MAX_LINGER variable - Set flr_share explicitly for renew tests - Add corner case for expect_fail_errno macro where test succeeds when it should've failed - Add a new intermediate patch, between remote test patch and reflect test patch, placing the netns setup inside the test file - Add missing skip for setuid fail, addressing stale code from harness migration - Delimit EXPECT and ASSERT usage (use former when test can continue) - Minor commit message rewording - Apply more missing scripts/checkpath.pl fixes v2: - Apply missing scripts/checkpath.pl fixes and other formatting enhancements - Add new basic IPV6_FL_A_RENEW tests - Put label after IPV6_FL_F_REMOTE test, freeing the value for a subsequent test - Delegate flowlabel_consistency configuration to wrapper sh script instead of doing it on the main test code - Skip IPV6_FL_F_REFLECT tests if flowlabel_consistency is set, instead of failing the test or attempting to change it - Compare resulting error for failure assertions - https://lore.kernel.org/all/[email protected]/ v1: - https://lore.kernel.org/all/[email protected]/ Marcelo Mendes Spessoto Junior (5): selftests: net: test IPV6_FL_A_RENEW selftests: net: test IPV6_FL_F_REMOTE selftests: net: create own netns in ipv6_flowlabel_mgr selftests: net: test IPV6_FL_F_REFLECT selftests: net: adopt harness for flow label mgr tools/testing/selftests/net/ipv6_flowlabel.sh | 2 +- .../selftests/net/ipv6_flowlabel_mgr.c | 584 ++++++++++++++---- 2 files changed, 466 insertions(+), 120 deletions(-) -- 2.55.0
