On Mon, Aug 10, 2026 at 10:16:26AM +0200, Krzysztof Kozlowski wrote: > On 06/08/2026 21:55, Saravanakrishnan Krishnamoorthy wrote: > > From: Alex Ousherovitch <[email protected]> > > > > Add device tree binding schema for the Rambus CryptoManager Hub (CMH) > > hardware crypto accelerator. The binding describes the parent > > SoC-level node with its SIC register region and one mailbox@N child > > node per mailbox the host owns, each carrying a reg (mailbox instance > > index), an optional interrupt, VCQ ring geometry (rambus,slots-log2 / > > rambus,strides-log2) and a rambus,cores affinity list. Which crypto cores > > are present is discovered from the SIC CORE_ENABLE register at probe, > > not described in the device tree. > > > > Register the 'rambus' vendor prefix for Rambus Inc. > > > > Co-developed-by: Saravanakrishnan Krishnamoorthy > > <[email protected]> > > Signed-off-by: Saravanakrishnan Krishnamoorthy <[email protected]> > > Completely messed order of tags. > > > Signed-off-by: Alex Ousherovitch <[email protected]> > > How Alex could sign after you? > > > Reviewed-by: Joel Wittenauer <[email protected]> > > Reviewed-by: Thi Nguyen <[email protected]> > > Your SoB is the last. > > Are you sure these people reviewed THIS code instead of blanket-review > for everything? > > Did they find any issues in the schema which you fixed? > > > > --- > > .../bindings/crypto/rambus,cmh.yaml | 207 ++++++++++++++++++
Also filename should match compatible. Best regards, Krzysztof
