On Mon, Aug 17, 2026 at 04:06:16PM +0800, Hongfu Li wrote:
> From: Hongfu Li <[email protected]>
> 
> Remove duplicate open() for local pagemap_fd in mprotect_tests() that
> shadows the global pagemap_fd already opened in main(). The local fd
> is never used in the function.
> 
> Signed-off-by: Hongfu Li <[email protected]>

Reviewed-by: Anshuman Khandual <[email protected]>

> ---
>  tools/testing/selftests/mm/pagemap_ioctl.c | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/tools/testing/selftests/mm/pagemap_ioctl.c 
> b/tools/testing/selftests/mm/pagemap_ioctl.c
> index cfd1987339c1..eadc7159ca5b 100644
> --- a/tools/testing/selftests/mm/pagemap_ioctl.c
> +++ b/tools/testing/selftests/mm/pagemap_ioctl.c
> @@ -1332,12 +1332,6 @@ int mprotect_tests(void)
>       int ret;
>       char *mem, *mem2;
>       struct page_region vec;
> -     int pagemap_fd = open("/proc/self/pagemap", O_RDONLY);
> -
> -     if (pagemap_fd < 0) {
> -             fprintf(stderr, "open() failed\n");
> -             exit(1);
> -     }
>  
>       /* 1. Map two pages */
>       mem = mmap(0, 2 * page_size, PROT_READ|PROT_WRITE, MAP_PRIVATE | 
> MAP_ANON, -1, 0);
> -- 
> 2.54.0
> 

Reply via email to