On 8/24/26 4:21 PM, Hamza Mahfooz wrote: > On Mon, Aug 24, 2026 at 12:39:06PM +0530, Muhammad Falak R Wani wrote: >> mana_bpf() declares an uninitialized 'ret' and falls through to a >> trailing 'return ret;' after a switch statement whose every case >> (XDP_SETUP_PROG and default) already returns unconditionally. This >> statement is therefore unreachable dead code left over from an >> earlier refactor, and it would return an uninitialized value if it >> were ever reached. >> >> Drop the unused variable and the unreachable return. >> >> Signed-off-by: Muhammad Falak R Wani <[email protected]> > > Fixes: ed5356b53f07 ("net: mana: Add XDP support") > Reviewed-by: Hamza Mahfooz <[email protected]> Please note that the current guidance is no fixes tag for net-next changes.
Also this specific change does not address any real issue, it's just code cleanup. /P
