On Mon, Aug 24, 2026 at 01:00:34PM -0700, Sean Christopherson wrote: > > > > There shouldn't be a need to "pad reset_vector to its full size of 16 > > bytes" as stated in v8 [1]. The exported "reset_vector" symbol in v8, > > plus the boot code start & end markers, should be enough to help > > tdx_vm_setup_boot_code_region() put this boot blob in the right place. > > Ya, looking at this with fresh eyes, AFAICT there's no reason to handcode > anything, > it's just basic arithmetic. > > Side topic, this series doesn't compile for me, so the below isn't even > properly > compile-tested (I hacked in arbitrary literals to get past the undefined > references). > > /usr/bin/x86_64-linux-gnu-ld.bfd: > tools/testing/selftests/kvm/lib/x86/tdx/td_boot.S:26:(.text+0xf): undefined > reference to `TD_BOOT_PARAMETERS_PER_VCPU' > /usr/bin/x86_64-linux-gnu-ld.bfd: > tools/testing/selftests/kvm/lib/x86/tdx/td_boot.S:30:(.text+0x17): undefined > reference to `TD_PER_VCPU_PARAMETERS_ESP_GVA' > /usr/bin/x86_64-linux-gnu-ld.bfd: > tools/testing/selftests/kvm/lib/x86/tdx/td_boot.S:33:(.text+0x1d): undefined > reference to `TD_BOOT_PARAMETERS_GDT' > /usr/bin/x86_64-linux-gnu-ld.bfd: > tools/testing/selftests/kvm/lib/x86/tdx/td_boot.S:37:(.text+0x26): undefined > reference to `TD_BOOT_PARAMETERS_IDT' > /usr/bin/x86_64-linux-gnu-ld.bfd: > tools/testing/selftests/kvm/lib/x86/tdx/td_boot.S:44:(.text+0x2f): undefined > reference to `TD_BOOT_PARAMETERS_CR4' > /usr/bin/x86_64-linux-gnu-ld.bfd: > tools/testing/selftests/kvm/lib/x86/tdx/td_boot.S:46:(.text+0x38): undefined > reference to `TD_BOOT_PARAMETERS_CR3' > /usr/bin/x86_64-linux-gnu-ld.bfd: > tools/testing/selftests/kvm/lib/x86/tdx/td_boot.S:48:(.text+0x41): undefined > reference to `TD_BOOT_PARAMETERS_CR0' > /usr/bin/x86_64-linux-gnu-ld.bfd: > tools/testing/selftests/kvm/lib/x86/tdx/td_boot.S:54:(.text+0x51): undefined > reference to `TD_PER_VCPU_PARAMETERS_GUEST_CODE' The patch series posted here on the mailing list is correct, but I made a one-line mistake when pushing the code to the GitHub branch. I have just force-pushed the fix to the branch. It should compile correctly now. Please let me know if you run into any further compilation issues.
I will test this change on my side. Thanks! Lisa
