Re: [PATCH net-next 1/2] netdevsim: add link speed support

[Hangbin Liu]

On Mon, Aug 31, 2026 at 02:16:46PM +0200, Andrew Lunn wrote:
> >  static void nsim_ethtool_ring_init(struct netdevsim *ns)
> > @@ -250,12 +276,16 @@ void nsim_ethtool_init(struct netdevsim *ns)
> >     ns->ethtool.fec.active_fec = ETHTOOL_FEC_NONE;
> >  
> >     ns->ethtool.channels = ns->nsim_bus_dev->num_queues;
> > +   ns->ethtool.duplex = DUPLEX_FULL;
> > +   ns->ethtool.speed = SPEED_5000;
> >  
> >     ethtool = debugfs_create_dir("ethtool", ns->nsim_dev_port->ddir);
> >     ns->ethtool_ddir = ethtool;
> >  
> >     debugfs_create_u32("get_err", 0600, ethtool, &ns->ethtool.get_err);
> >     debugfs_create_u32("set_err", 0600, ethtool, &ns->ethtool.set_err);
> > +   debugfs_create_u32("speed", 0600, ethtool, &ns->ethtool.speed);
> > +   debugfs_create_u8("duplex", 0600, ethtool, &ns->ethtool.duplex);
> 
> debugfs_create_bool() ?

I'm not sure if anyone want to set nsim duplex to unknown for testing.
Do you think that we should disable this behavior?

Thanks
Hangbin