mana_bpf() has a trailing 'return ret;' after a switch statement whose every case (XDP_SETUP_PROG and default) already returns unconditionally. The statement is therefore unreachable and 'ret' is never used.
Remove both. No functional change intended. Signed-off-by: Muhammad Falak R Wani <[email protected]> Reviewed-by: Hamza Mahfooz <[email protected]> --- v2: - reword the commit message: drop the claim that an uninitialized value could be returned; every switch case returns unconditionally, so the statement is simply unreachable. Describe it as a pure cleanup. - drop the Fixes: tag offered during v1 review, per the guidance that net-next changes should not carry Fixes: tags. - no code changes. v1: https://lore.kernel.org/netdev/[email protected]/ drivers/net/ethernet/microsoft/mana/mana_bpf.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/ethernet/microsoft/mana/mana_bpf.c b/drivers/net/ethernet/microsoft/mana/mana_bpf.c index 53308e139cbe9..70bb8c9dc3413 100644 --- a/drivers/net/ethernet/microsoft/mana/mana_bpf.c +++ b/drivers/net/ethernet/microsoft/mana/mana_bpf.c @@ -253,7 +253,6 @@ static int mana_xdp_set(struct net_device *ndev, struct bpf_prog *prog, int mana_bpf(struct net_device *ndev, struct netdev_bpf *bpf) { struct netlink_ext_ack *extack = bpf->extack; - int ret; switch (bpf->command) { case XDP_SETUP_PROG: @@ -262,6 +261,4 @@ int mana_bpf(struct net_device *ndev, struct netdev_bpf *bpf) default: return -EOPNOTSUPP; } - - return ret; } -- 2.55.0
