> mana_hwc_send_request() gates the HWC destination queue IDs on > gc->is_pf, which the PCI probe derives from the device ID. > > The gate is not needed. hwc->pf_dest_vrq_id and hwc->pf_dest_vrcq_id are > only ever assigned from the HWC_INIT_DATA_PF_DEST_RQ_ID and > HWC_INIT_DATA_PF_DEST_CQ_ID init events, and the hardware always > reports values that are valid for the function it sends them to. > > Signed-off-by: Manish Awasthi <[email protected]>
Reviewed-by: Long Li <[email protected]> > --- > drivers/net/ethernet/microsoft/mana/hw_channel.c | 16 +++++++++------- > 1 file changed, 9 insertions(+), 7 deletions(-) > > diff --git a/drivers/net/ethernet/microsoft/mana/hw_channel.c > b/drivers/net/ethernet/microsoft/mana/hw_channel.c > index 263e7c4e2934..5d75c2478a8a 100644 > --- a/drivers/net/ethernet/microsoft/mana/hw_channel.c > +++ b/drivers/net/ethernet/microsoft/mana/hw_channel.c > @@ -855,13 +855,12 @@ void mana_hwc_destroy_channel(struct > gdma_context *gc) int mana_hwc_send_request(struct hw_channel_context > *hwc, u32 req_len, > const void *req, u32 resp_len, void *resp) { > - struct gdma_context *gc = hwc->gdma_dev->gdma_context; > struct hwc_work_request *tx_wr; > struct hwc_wq *txq = hwc->txq; > struct gdma_req_hdr *req_msg; > struct hwc_caller_ctx *ctx; > - u32 dest_vrcq = 0; > - u32 dest_vrq = 0; > + u32 dest_vrcq; > + u32 dest_vrq; > u32 command; > u16 msg_id; > int err; > @@ -890,10 +889,13 @@ int mana_hwc_send_request(struct > hw_channel_context *hwc, u32 req_len, > tx_wr->msg_size = req_len; > command = req_msg->req.msg_type; > > - if (gc->is_pf) { > - dest_vrq = hwc->pf_dest_vrq_id; > - dest_vrcq = hwc->pf_dest_vrcq_id; > - } > + /* The hardware reports the HWC destination queues through > + * HWC_INIT_DATA_PF_DEST_RQ_ID and > HWC_INIT_DATA_PF_DEST_CQ_ID, and > + * always supplies values that are valid for this function, so no > + * PF-specific handling is needed here. > + */ > + dest_vrq = hwc->pf_dest_vrq_id; > + dest_vrcq = hwc->pf_dest_vrcq_id; > > err = mana_hwc_post_tx_wqe(txq, tx_wr, dest_vrq, dest_vrcq, false); > if (err) { > > base-commit: 1b78070aaef63512688aebfbc82365ef9d6660f1 > -- > 2.54.0
