842_DECOMPRESS_KUNIT_TEST selects the decompressor even when no other
option needs it, including through KUNIT_ALL_TESTS.

Depend on 842_DECOMPRESS as required by
Documentation/dev-tools/kunit/style.rst. This also prevents the test from
promoting a modular decompressor to built-in.

Fixes: cca072cb1423 ("lib/842: add KUnit tests for the decompressor")
Reported-by: Geert Uytterhoeven <[email protected]>
Closes: 
https://lore.kernel.org/r/camuhmdvcz5cv4-hrjlyffkh6ushivxq5excnyp0z1k_smav...@mail.gmail.com/
Assisted-by: LLM
Signed-off-by: Karl Mehltretter <[email protected]>
---
Follow-up to the accepted commit, based on cryptodev-2.6/master.

Testing: Checked Kconfig dependency resolution for eight x86_64
configurations before and after the change, including KUNIT_ALL_TESTS
and modular/built-in combinations.

 lib/Kconfig.debug | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index 48201092b3df..49f74005394b 100644
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -2228,7 +2228,7 @@ if RUNTIME_TESTING_MENU
 config 842_DECOMPRESS_KUNIT_TEST
        tristate "KUnit tests for the 842 decompressor" if !KUNIT_ALL_TESTS
        depends on KUNIT
-       select 842_DECOMPRESS
+       depends on 842_DECOMPRESS
        default KUNIT_ALL_TESTS
        help
          Enable stream-validation and boundary tests for the software 842

base-commit: 9e06d371730b841ad8fe79ebfccf0def9470201f
-- 
2.39.5 (Apple Git-154)

Reply via email to