On Tue, Sep 22, 2026 at 6:33 AM Jeff Jo <[email protected]> wrote: > > On Tue, Sep 22, 2026 at 02:08:47AM +0200, Eric Dumazet wrote: > > Note: Even with existing packetdrill binaries in the wild that don't > > check TS ecr, > > tp->rx_opt.ts_recent is still directly testable in pure .pkt via PAWS > > (tcp_paws_discard()), > > the same way tcp_ts_recent_invalid_ack.pkt works: > > Thanks for the feedback. I'll send a v2 series tomorrow removing the > redundant SYN_RECV check and replacing the test with a plain .pkt test > that uses PAWS for the assertion. I've verified that the revised test > detects the bug with unmodified packetdrill and passes with the > simplified kernel fix. > > For the PAWS probe, I used TSval 300998 rather than 300999, since > Linux's one-tick PAWS tolerance allows the latter through. > > I'll follow up with a separate packetdrill fix. How does that sound?
I saw you sent the packetdrill patch for formal inclusion. Let's wait for it to be merged and our runners to be updated, as the kernel bug is minor. This will allow us to get a nicer packetdrill test that exposes the issue directly instead of via a workaround. Thanks!
