On Tue, 22 Sept 2026 at 14:30, Paolo Abeni <[email protected]> wrote: > > On 9/21/26 20:39, [email protected] wrote: > > Thank you for your contribution! Sashiko AI review found 2 potential > > issue(s) to consider. > > > > Critical: 0 · High: 0 · Medium: 2 · Low: 0 > > > > If you believe none of the issues are legitimate, please reply to each > > issue of Medium severity or higher and explain why the AI is wrong. > > If any of them are legitimate and you plan to respin, please let patchwork > > know by including "pw-bot: cr" as a separate line at the end of your reply > > (one such reply per series is enough). > > > > - [Medium] The new error-queue splice is dead code for MPTCP-native data: > > its only accepted input (SO_EE_ORIGIN_TIMESTAMPING skbs on a subflow… > > - [Medium] Forwarded TX timestamps expose per-subflow identifiers instead > > of parent-socket byte-stream identifiers, breaking the… > Sashiko comments look relevant to me. Basically this work makes sense > if proper support for mptcp-level tx timestamping is enabled and the > and sk_tskey is resolved at the msk level. > > I underlook at the above during reviews on the mptcp ML. > > IDK if someone is currently working on the missing work/bits. > > /P >
Agreed, nothing arms tx timestamps on the msk today. Let's drop the series for now. I can look into it. pw-bot: cr
