On 23/09/2026 12:32, Sebastian Andrzej Siewior wrote: > Would adding a NETIF_F_HSR_SLAVE flag to slave device(s) and then filter > invalid flags in netdev_fix_features() fix this? This should help > against enabling and add a warning if a flag can not be removed. > > A netdev_change_features() might do the job then. > > Sebastian
Yes. I'll use a port constraint in netdev_fix_features() to keep GRO, and GRO_HW (when configurable) disabled, while the device is an HSR/PRP port, incl. the interlink port. And call netdev_change_features() on attachment and detachment, preserving the GRO settings. -- Xin
