On Thu, Sep 24, 2026 at 11:34:29PM +0300, Igor Velkov via B4 Relay wrote: > From: Igor Velkov <[email protected]> > > When the build forces colored diagnostics, e.g. with > KCFLAGS=-fdiagnostics-color=always, the compiler wraps the expected > error in ANSI escape sequences and the grep does not match it. Every > test then reports "lacked '__write_overflow' warning" although FORTIFY > caught the overflow, and a real FORTIFY regression looks the same. > > warning: unsafe strcpy() usage lacked '__write_overflow' warning in > lib/test_fortify/write_overflow-strcpy.c > > Pass -fdiagnostics-color=never after the caller's flags so that the > test compile always emits plain text. > > Fixes: be58f7103700 ("fortify: Add compile-time FORTIFY_SOURCE tests") > Assisted-by: LLM > Signed-off-by: Igor Velkov <[email protected]> > --- > Found in Armbian kernel builds, which pass -fdiagnostics-color=always > in KCFLAGS: all 18 tests reported "lacked".
Hmmm, interesting default... That said, seems reasonable to me. Presumably it is more complicated to handle this in the regex. Reviewed-by: Nathan Chancellor <[email protected]> > Tested on arm64, 7.2.y, KCFLAGS=-fdiagnostics-color=always, > building lib/test_fortify/ (tests ok out of 18): > > before after after, -D__NO_FORTIFY > GCC 14.2 0 18 0 > clang 19.1.7 0 18 0 > > An LLM assistant found the cause, wrote the fix and the changelog, > and ran the tests; I reviewed all of it. > --- > lib/test_fortify/test_fortify.sh | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/lib/test_fortify/test_fortify.sh > b/lib/test_fortify/test_fortify.sh > index ad6dd44fa31c..c07eb3302c9d 100644 > --- a/lib/test_fortify/test_fortify.sh > +++ b/lib/test_fortify/test_fortify.sh > @@ -37,7 +37,8 @@ export LANG=C > > status= > # Attempt to build a source that is expected to fail with a specific warning. > -if "$@" -Werror -c "$IN" -o "$OUT".o 2> "$TMP" ; then > +# Disable colors so that the grep below can match the warning. > +if "$@" -Werror -fdiagnostics-color=never -c "$IN" -o "$OUT".o 2> "$TMP" ; > then > # If the build succeeds, either the test has failed or the > # warning may only happen at link time (Clang). In that case, > # make sure the expected symbol is unresolved in the symbol list. > > --- > base-commit: 760f96b7f54beb8dc6f85d97ac7854fddba86835 > change-id: 20260924-fortify-test-color-f34a31b56bcc > > Best regards, > -- > Igor Velkov <[email protected]> > > -- Cheers, Nathan
