Harvey Harrison : > arch/x86/kernel/kprobes.c:584:16: warning: symbol > 'kretprobe_trampoline_holder' was not declared. Should it be static? > arch/x86/kernel/kprobes.c:676:6: warning: symbol 'trampoline_handler' was not > declared. Should it be static? > > Make them static and add the __used attribute, approach taken from the > arm kprobes implementation. > > kretprobe_trampoline_holder uses inline assemly to define the global > symbol kretprobe_trampoline, but nothing ever calls the holder explicitly. > > trampoline handler is only called from inline assembly in the same file, > mark it used and static. > > Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
It looks good to me. Acked-by: Masami Hiramatsu <[EMAIL PROTECTED]> Thank you, -- Masami Hiramatsu Software Engineer Hitachi Computer Products (America) Inc. Software Solutions Division e-mail: [EMAIL PROTECTED] -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/