Hello, Tao. The following is a Claude-generated review.
On Wed, 30 Sep 2026 15:51:54 +0800, Tao Cui wrote: > + When CONFIG_BLK_CGROUP_IOCOST_BPF is enabled, a BPF cost model > + can be attached to a device by loading an "iocost_model_ops" > + struct_ops with the whole disk's major:minor in its "dev" member ... > + switches back to the builtin model, and neither detaches the > + struct_ops; only detaching removes the model, after which > + "model=bpf" fails. "ctrl" keeps describing the builtin Attaching, not loading, binds the model. The test loads a second model fine and only its attach fails. Device removal also removes the model, and the user still has to tear down the struct_ops link afterwards. Can you mention that too? Thanks. -- tejun
