> -----Original Message----- > From: Jonathan Cameron <[email protected]> > Sent: Tuesday, September 22, 2026 7:14 AM > To: Manish Honap <[email protected]> > Cc: [email protected]; [email protected]; Ankit Agrawal <[email protected]>; > [email protected]; [email protected]; Srirangan > Madhavan <[email protected]>; [email protected]; > [email protected]; [email protected]; [email protected]; > [email protected]; [email protected]; [email protected]; Yishai > Hadas <[email protected]>; Shameer Kolothum Thodi > <[email protected]>; [email protected]; [email protected]; > [email protected]; [email protected]; [email protected]; Neo Jia > <[email protected]>; Krishnakant Jaju <[email protected]>; Vikram Sethi > <[email protected]>; Zhi Wang <[email protected]>; linux- > [email protected]; [email protected]; [email protected]; > [email protected]; [email protected]; linux- > [email protected]; [email protected] > Subject: Re: [PATCH v5 03/27] cxl: Move component register defines to > uapi/cxl/cxl_regs.h > > External email: Use caution opening links or attachments > > > On Thu, 17 Sep 2026 00:05:16 +0530 > <[email protected]> wrote: > > > From: Manish Honap <[email protected]> > > > > The CXL component and HDM decoder register layout is spec-defined and > > is needed by a userspace consumer that cannot include the private > > drivers/cxl/cxl.h > > > > The vfio-cxl selftest > > (tools/testing/selftests/vfio/vfio_cxl_type2_test.c) builds against > > installed uapi headers only. Move those defines to a new uapi header, > > the way PCI register offsets live in uapi pci_regs.h, and include it > > from drivers/cxl/cxl.h so existing in-kernel users are unchanged. > > > > No functional change; the GENMASK and BIT forms are written as plain > > values as a uapi header requirement. > > I thought we'd fixed that these days... And indeed we have see > include/uapi/linux/bits.h for __GENMASK() and include/uapi/linux/const.h for > _BITUL() > > Both are in use in pci_regs.h for instance.
Thank you. I think I missed these. I will update the file and the commit message accordingly. > > Jonathan
