Re: [PATCH v5 2/3] kselftest: mm: remove HPAGE_SIZE and HPAGE_SHIFT macro

[Kiryl Shutsemau]

On Fri, Oct 09, 2026 at 02:27:33AM +0100, Yeoreum Yun wrote:
> +uint64_t pmd_pshift(void)
> +{
> +     if (__pmd_pshift != -1ull)
> +             return __pmd_pshift;
> +
> +     if (__pmd_psize != -1ull)
> +             __pmd_psize = pmd_psize();

Sashiko pointed that this check is inverted.

> +
> +     __pmd_pshift = (__pmd_psize > 0) ? ffsl(__pmd_psize) - 1 : 0;
> +
> +     return __pmd_pshift;
>  }

-- 
  Kiryl Shutsemau / Kirill A. Shutemov