The previous version of the patch had a new header ti_sci_dev.h, that mirrors ti_sci_proc.h in terms of the struct decl and its helper function structure, with the goal of abstracting all ti_sci_handle's members like ti_sci_dev_ops from being invoked directly in the driver code.
Lore link to the v1 patch: https://lore.kernel.org/all/[email protected]/ Upon discussing in the original patch thread, it seemed better to combine ti_sci_proc.h and ti_sci_dev.h's structs and merge all their helpers into a single header. That is what ti_sci_ctrl.h aims to do: It has the union of tsd (ti_sci_dev) and tsp (ti_sci_proc) and both their helper functions are prefixed with ti_sci_ctrl_dev and ti_sci_ctrl_proc respectively. The goal of the patch (v2) is to maintain a single source of origin for all ti_sci_dev/proc_ops call sites. Any stray calls to dev_ops/proc_ops function pointer members in driver code should eventually be abstracted through this header (ti_sci_ctrl.h). In the future we can try to abstract tsd's dev_ops even further through pm_runtime, but there are some roadblocks that I am unaware of, so that warranties a different patch. Siddharth Karanam (2): remoteproc: Add ti_sci_dev_ops abstraction remoteproc: Merge ti_sci_dev and ti_sci_proc abstraction drivers/remoteproc/ti_k3_common.c | 21 +-- drivers/remoteproc/ti_k3_common.h | 6 +- drivers/remoteproc/ti_k3_dsp_remoteproc.c | 26 ++-- drivers/remoteproc/ti_k3_m4_remoteproc.c | 23 ++- drivers/remoteproc/ti_k3_r5_remoteproc.c | 66 +++----- drivers/remoteproc/ti_sci_ctrl.h | 177 ++++++++++++++++++++++ drivers/remoteproc/ti_sci_proc.h | 130 ---------------- 7 files changed, 231 insertions(+), 218 deletions(-) create mode 100644 drivers/remoteproc/ti_sci_ctrl.h delete mode 100644 drivers/remoteproc/ti_sci_proc.h -- 2.55.0
