On 10/15/26 2:32 PM, Frieder Hannenheim wrote:
> Add initial device-tree for the OnePlus 8T. Downstream reference is [1].
>
> [1]
> https://github.com/LineageOS/android_kernel_oneplus_sm8250/blob/lineage-23.2/arch/arm64/boot/dts/vendor/oplus/kona-kebab-overlay.dts
>
> Signed-off-by: Frieder Hannenheim <[email protected]>
> Co-developed-by: Robert Oscilowski <[email protected]>
> Signed-off-by: Robert Oscilowski <[email protected]>
> ---
> Documentation/devicetree/bindings/arm/qcom.yaml | 1 +
> arch/arm64/boot/dts/qcom/Makefile | 1 +
> arch/arm64/boot/dts/qcom/sm8250-oneplus-kebab.dts | 129
> ++++++++++++++++++++++
Better. Please split off the dt-bindings changes to a separate patch,
and put it first in the series.
[...]
> +&framebuffer {
> + width = <1080>;
> + height = <2400>;
> + stride = <(1080 * 4)>;
Does the resolution differ between the two devices?
> +};
> +
> +&i2c2 {
> + status = "okay";
> +
> + pm8008: pmic@8 {
> + compatible = "qcom,pm8008";
Is it not present on the other one?
> + reg = <0x8>;
> +
> + interrupt-parent = <&tlmm>;
> + interrupts = <112 IRQ_TYPE_EDGE_RISING>;
> +
> + reset-gpios = <&tlmm 93 GPIO_ACTIVE_LOW>;
> +
> + vdd-l1-l2-supply = <&vreg_s8c_1p3>;
> + vdd-l3-l4-supply = <&vreg_bob>;
> + vdd-l5-supply = <&vreg_bob>;
> + vdd-l6-supply = <&vreg_bob>;
> + vdd-l7-supply = <&vreg_bob>;
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&pm8008_default>, <&pm8008_interrupt>;
nit:
property-n
property-names
in this order, file-wide, please
[...]
> +&i2c16 {
> + status = "okay";
> +
> + fuel-gauge@55 {
> + compatible = "ti,bq28z610";
> + reg = <0x55>;
> + monitored-battery = <&battery>;
> + };
Likewise, is this absent on the other phone?
> +};
> +
> +&tlmm {
> + pm8008_default: pm8008-default-state {
> + pins = "gpio93";
> + function = "gpio";
> + bias-pull-up;
> + output-high;
Drop the output-high, the driver will set it for you
Konrad
