On Sat, 16 Feb 2008 01:27:41 -0800 (PST) David Miller <[EMAIL PROTECTED]> wrote:
> From: [EMAIL PROTECTED]
> Date: Fri, 15 Feb 2008 20:49:33 -0800
>
> > Subject: bluetooth: fix warning in net/bluetooth/hci_sysfs.c
> > From: Andrew Morton <[EMAIL PROTECTED]>
> >
> > net/bluetooth/hci_sysfs.c: In function 'del_conn':
> > net/bluetooth/hci_sysfs.c:339: warning: suggest parentheses around
> > assignment used as truth value
> >
> > Cc: Dave Young <[EMAIL PROTECTED]>
> > Cc: David S. Miller <[EMAIL PROTECTED]>
> > Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
>
> Linus barfed when this exact patch got posted a few weeks
> ago, he said he considers just adding parenthesis to quiet
> this warning awful and explicit NULL test should be used.
- while (dev = device_find_child(&conn->dev, NULL, __match_tty)) {
+ while ((dev = device_find_child(&conn->dev, NULL, __match_tty))) {
hrm.
box:/usr/src/linux-2.6.25-rc2> grep -r 'while [(][(].*{$' . | wc -l
1240
box:/usr/src/linux-2.6.25-rc2> grep -r 'while [(][(].*{$' . | grep -v NULL | wc
-l
867
so two thirds of them presently don't bother testing for NULL. It's a
pretty common idiom.
(adds the != NULL, sees that it reaches column 82, drops patch in disgust)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
