From: Leonardo Potenza <[EMAIL PROTECTED]>
Add a check for the sysfs_create_bin_file() return value.
In case of error the framebuffer creation is not aborted, but a warning message
is generated instead.
Signed-off-by: Leonardo Potenza <[EMAIL PROTECTED]>
---
The aim of this patch is to remove the following warning messages:
drivers/video/aty/radeon_base.c: In function 'radeonfb_pci_register':
drivers/video/aty/radeon_base.c:2334: warning: ignoring return value of
'sysfs_create_bin_file', declared with attribute warn_unused_result
drivers/video/aty/radeon_base.c:2336: warning: ignoring return value of
'sysfs_create_bin_file', declared with attribute warn_unused_result
The patch was already acknowledged by Benjamin Herrenschmidt, but I realised
that I did not cc the LKML (sorry for that).
--- linux-2.6.orig/drivers/video/aty/radeon_base.c
+++ linux-2.6/drivers/video/aty/radeon_base.c
@@ -2331,9 +2331,9 @@ static int __devinit radeonfb_pci_regist
/* Register some sysfs stuff (should be done better) */
if (rinfo->mon1_EDID)
- sysfs_create_bin_file(&rinfo->pdev->dev.kobj, &edid1_attr);
+ WARN_ON(sysfs_create_bin_file(&rinfo->pdev->dev.kobj,
&edid1_attr));
if (rinfo->mon2_EDID)
- sysfs_create_bin_file(&rinfo->pdev->dev.kobj, &edid2_attr);
+ WARN_ON(sysfs_create_bin_file(&rinfo->pdev->dev.kobj,
&edid2_attr));
/* save current mode regs before we switch into the new one
* so we can restore this upon __exit
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
