* Joerg Roedel <[EMAIL PROTECTED]> wrote:

> -     if (!highest_pfn) {
> +     if (!highest_pfn && !kvm_para_available()) {
>               printk(KERN_WARNING "WARNING: strange, CPU MTRRs all blank?\n");
>               WARN_ON(1);
> -             return 0;
>       }
>  
> +     if (!highest_pfn)
> +             return 0;

hm, why not have a single test for !highest_pfn:

        if (!highest_pfn) {
                if (!kvm_para_available()) {
                        printk(KERN_WARNING
                               "WARNING: strange, CPU MTRRs all blank?\n");
                        WARN_ON(1);
                }
                return 0;
        }

? But yeah, your patch looks good otherwise.

I'm not sure how we could detect pure Qemu instances - perhaps it should 
define some special MSR or something?

        Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to