> return do_mbind(start, len, mode, mode_flags, &nodes, flags);
The intermingling of 'flags', 'mode' and 'mode_flags' to refer to the low bits, the high bits or all the bits of the flags field is handled fairly carefully in your patch, but can still be a bit difficult to keep track of which is which when reading. I'll wager not many readers can immediately say what the 'mode', 'mode_flags' and 'flags' refer to, in the above code snippet, for example. Do you have any suggestions on how to further improve the clarity of this code? -- I won't rest till it's the best ... Programmer, Linux Scalability Paul Jackson <[EMAIL PROTECTED]> 1.940.382.4214 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/