On Thu, 2012-07-12 at 12:49 -0700, Jon Mason wrote: > On Thu, Jul 12, 2012 at 11:15 AM, Jeff Kirsher > <[email protected]> wrote: > > On Tue, 2012-07-10 at 15:43 -0700, Jeff Kirsher wrote: > >> On Tue, 2012-07-10 at 15:31 -0700, Jon Mason wrote: > >> > Remove unused IXGBE_INTEL_VENDOR_ID #define > >> > > >> > Signed-off-by: Jon Mason <[email protected]> > >> > Cc: Jeff Kirsher <[email protected]> > >> > Cc: Jesse Brandeburg <[email protected]> > >> > Cc: Bruce Allan <[email protected]> > >> > Cc: Carolyn Wyborny <[email protected]> > >> > Cc: Don Skidmore <[email protected]> > >> > Cc: Greg Rose <[email protected]> > >> > Cc: Peter P Waskiewicz Jr <[email protected]> > >> > Cc: Alex Duyck <[email protected]> > >> > Cc: John Ronciak <[email protected]> > >> > --- > >> > drivers/net/ethernet/intel/ixgbe/ixgbe_type.h | 3 --- > >> > 1 file changed, 3 deletions(-) > >> > >> This should also go through David Miller's networking tree's. > Adding > >> netdev mailing list. > >> > >> Acked-by: Jeff Kirsher <[email protected]> > > > > After looking at this further, I rescind my ACK. > > > > NAK, this define is used in several places in ixgbe_main.c and the > > driver will not compile with this patch. > > My apologies, I was a bit sloppy and simply rebased my old patches > without retesting them. The code has changed since I originally > pushed the patch (http://www.spinics.net/lists/netdev/msg171523.html). > I will fix and resubmit. > > Thanks, > Jon
Also note, that when you fix up the patch and resend it, could you resend patch 1 (ixgb) as well to [email protected]. That way netdev patchwork will pickup the patches and I can get them into my queue. Thanks! Jeff
signature.asc
Description: This is a digitally signed message part
