> -----Original Message-----
> From: Joe Perches [mailto:[email protected]]
> Sent: Saturday, July 14, 2012 4:25 PM
> To: KY Srinivasan
> Cc: [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]
> Subject: Re: [PATCH 01/15] Drivers: hv: Format GUIDS as per MSFT standards
>
> On Sat, 2012-07-14 at 13:34 -0700, K. Y. Srinivasan wrote:
> > Format GUIDS as per MSFT standard. This makes interacting with MSFT
> > tool stack easier.
> >
> > Signed-off-by: K. Y. Srinivasan <[email protected]>
> > Reviewed-by: Haiyang Zhang <[email protected]>
> > ---
> > drivers/hv/vmbus_drv.c | 4 ++--
> > 1 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c
> > index a220e57..1f7e54a 100644
> > --- a/drivers/hv/vmbus_drv.c
> > +++ b/drivers/hv/vmbus_drv.c
> > @@ -147,7 +147,7 @@ static ssize_t vmbus_show_device_attr(struct device
> *dev,
> >
> > if (!strcmp(dev_attr->attr.name, "class_id")) {
> > ret = sprintf(buf, "{%02x%02x%02x%02x-%02x%02x-%02x%02x-"
> > - "%02x%02x%02x%02x%02x%02x%02x%02x}\n",
> > + "%02x%02x-%02x%02x%02x%02x%02x%02x}\n",
> > device_info->chn_type.b[3],
> > device_info->chn_type.b[2],
> > device_info->chn_type.b[1],
> > @@ -166,7 +166,7 @@ static ssize_t vmbus_show_device_attr(struct device
> *dev,
> > device_info->chn_type.b[15]);
> > } else if (!strcmp(dev_attr->attr.name, "device_id")) {
> > ret = sprintf(buf, "{%02x%02x%02x%02x-%02x%02x-%02x%02x-"
> > - "%02x%02x%02x%02x%02x%02x%02x%02x}\n",
> > + "%02x%02x-%02x%02x%02x%02x%02x%02x}\n",
> > device_info->chn_instance.b[3],
> > device_info->chn_instance.b[2],
> > device_info->chn_instance.b[1],
>
> ret = sprintf(buf, "{%pUl}\n", device_info->chn_instance.b);
Thank you Joe. I recall seeing some patches from you a longtime ago on this.
I was just modifying existing code in this patch; if it is ok with you I will
send a
separate patch using the preferred format string for printing GUIDS.
Regards,
K. Y
N�����r��y����b�X��ǧv�^�){.n�+����{����zX����ܨ}���Ơz�&j:+v�������zZ+��+zf���h���~����i���z� �w���?�����&�)ߢf��^jǫy�m��@A�a���
0��h���i
