On Wed, 2012-07-18 at 14:40 -0600, Toshi Kani wrote: > This patch introduces acpi_pr_<level>(), where <level> is a message > level such as err/warn/info, to support improved logging messages > for ACPI, esp. in hotplug operations. acpi_pr_<level>() appends > "ACPI" prefix and ACPI object path to the messages. This improves > diagnostics in hotplug operations since it identifies an object that > caused an issue in a log file. > > acpi_pr_<level>() takes acpi_handle as an argument, which is passed > to ACPI hotplug notify handlers from the ACPI CA. Therefore, it is > always available unlike other kernel objects, such as device.
Hi Toshi. I'd be tempted to instead make the calls more like other <subsystem>_<level> uses and rename these to acpi_<level> and change the existing acpi_info to another name. Other than that, seems fine to me. cheers, Joe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
